Bug 10795 - Improvements for GetOpenIssue in C4::Circulation
Summary: Improvements for GetOpenIssue in C4::Circulation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: kenza
QA Contact: Testopia
URL:
Keywords:
Depends on: 10683
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-28 08:31 UTC by kenza
Modified: 2014-12-07 20:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10795 - Improvements for GetOpenIssue in C4::Circulation (1.26 KB, patch)
2013-08-28 08:50 UTC, kenza
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10795 - Improvements for GetOpenIssue in C4::Circulation (1.53 KB, patch)
2013-08-31 02:21 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 10795 - Improvements for GetOpenIssue in C4::Circulation (1.57 KB, patch)
2013-09-06 15:59 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description kenza 2013-08-28 08:31:45 UTC

    
Comment 1 kenza 2013-08-28 08:50:11 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-08-31 02:21:43 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-09-06 15:59:10 UTC
Created attachment 20828 [details] [review]
Bug 10795 - Improvements for GetOpenIssue in C4::Circulation

This patch adds some improvements for the routine GetOpenIssue.
Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue.

To test:
prove t/db_dependent/Circulation_issue.t
t/db_dependent/Circulation_issue.t .. ok
All tests successful.
Files=1, Tests=16,  2 wallclock secs ( 0.06 usr  0.01 sys +  1.09 cusr  0.07 csys =  1.23 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Same situation as the one noted in comment of
Bug 10683, test fails unless there is an issuingrule
All, All with 1 as renewals allowed.

With that condition, it succeeds

No koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2013-10-09 04:00:13 UTC
Pushed to master.  Thanks, Kenza!