Bug 10797 - Move styling from element to CSS file for search input field in OPAC
Summary: Move styling from element to CSS file for search input field in OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-28 10:08 UTC by Katrin Fischer
Modified: 2015-06-04 23:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10797: Move styling of simple search from element to CSS file (2.19 KB, patch)
2013-12-04 14:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 10797: Move styling of simple search from element to CSS file (2.24 KB, patch)
2013-12-22 20:22 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10797: Move styling of simple search from element to CSS file (2.36 KB, patch)
2013-12-23 14:06 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-08-28 10:08:52 UTC
To make it easier to style the simple search box in the OPAC the CSS should be moved from the style attribute to the CSS files:

<input id="transl1" class="left" type="text" title="Suchbegriffe eingeben" style="font-size: 120%; width: 35%;" name="q">
Comment 1 Katrin Fischer 2013-12-04 14:43:50 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-12-22 20:22:43 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-12-23 14:06:58 UTC
Created attachment 23785 [details] [review]
Bug 10797: Move styling of simple search from element to CSS file

To test:
- Switch to prog theme, problem doesn't exist in Bootstrap theme
- Take a look at the simple search input field
- Apply patch
- Refresh page
- Make sure field has the same length and size

You can also use Firebug to make sure the same styles
are applied to the element before and after the change.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2013-12-23 15:33:41 UTC
Pushed to master.  Thanks, Katrin!
Comment 5 Fridolin Somers 2013-12-30 10:05:23 UTC
Patch pushed to 3.14.x, will be in 3.14.2.
(this patch is not needed for bootstrap theme).