Bug 1080 - How about telling the template to make a noise on circulation errors?
Summary: How about telling the template to make a noise on circulation errors?
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: PC All
: P2 enhancement (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-31 05:49 UTC by Michael Hafen
Modified: 2012-10-25 01:08 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patches. (7.85 KB, patch)
2006-05-31 05:49 UTC, Chris Cormack
Details | Diff | Splinter Review
Git patch which contains swf files. (18.45 KB, patch)
2008-08-25 13:09 UTC, Chris Cormack
Details | Diff | Splinter Review
Slight changes to audio feedback, including putting the html object code in an included file (5.97 KB, patch)
2008-08-25 13:10 UTC, Chris Cormack
Details | Diff | Splinter Review
git patch which changes the swf files to wav files (82.96 KB, patch)
2008-08-25 13:11 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-20 23:38:38 UTC


---- Reported by mdhafen@tech.washk12.org 2006-05-31 05:49:22 ----

Could code be added to notify the templates that a noise should be made where there is an error during circulation?



---- Additional Comments From mdhafen@tech.washk12.org 2006-05-31 05:49:38 ----

Created an attachment
proposed patches.





---- Additional Comments From chris@bigballofwax.co.nz 2006-06-01 20:53:39 ----

A great idea, do you know what code we would need to put in the templates to make a sound work?



---- Additional Comments From mdhafen@tech.washk12.org 2006-06-02 04:05:09 ----

(In reply to comment #2)
> A great idea, do you know what code we would need to put in the templates to
> make a sound work?
> 

Something like : 

                <!-- TMPL_IF NAME="ERROR_SOUND" -->
                <EMBED src="<!-- TMPL_VAR name="themelang" -->/images/error.swf" quality="high"  WIDTH="1" HEIGHT="1" TYPE="application/x-shockwave-flash" PLUGINSPAGE="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash"></EMBED>
                <!-- /TMPL_IF -->



---- Additional Comments From jmf@liblime.com 2007-10-04 13:59:17 ----

bumping up to 3.0



---- Additional Comments From oleonard@myacpl.org 2008-08-25 11:43:50 ----

Michael, did create a Flash file to go with this patch?



---- Additional Comments From mdhafen@tech.washk12.org 2008-08-25 13:01:08 ----

(In reply to comment #5)
> Michael, did create a Flash file to go with this patch?
> 

Yeah, I have a git patch with that, and one with a wav file too.  I've found that Firefox on Windows doesn't handle wav objects well, so I've stuck with flash for my install here.  I'll post both patches here though, as soon as I have to chance to rebase my branch.




---- Additional Comments From mdhafen@tech.washk12.org 2008-08-25 13:09:30 ----

Created an attachment
Git patch which contains swf files.





---- Additional Comments From mdhafen@tech.washk12.org 2008-08-25 13:10:20 ----

Created an attachment
Slight changes to audio feedback, including putting the html object code in an included file





---- Additional Comments From mdhafen@tech.washk12.org 2008-08-25 13:11:20 ----

Created an attachment
git patch which changes the swf files to wav files

I don't like this patch because Firefox on Windows doesn't handle embedded wav's well.



---- Additional Comments From oleonard@myacpl.org 2008-09-25 05:53:13 ----

*** http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2574 has been marked as a duplicate of this bug. ***



---- Additional Comments From nengard@gmail.com 2009-12-23 17:46:46 ----

Does this still need work?



---- Additional Comments From mdhafen@tech.washk12.org 2010-01-05 15:10:15 ----

These patches probably won't apply against the current code base, but I've got a git repo where they are current:  git://development.washk12.org/koha on the WCSD branch.

Other than that I think this is finished.



---- Additional Comments From nengard@gmail.com 2010-01-05 16:36:23 ----

This bug says it should apply to HEAD - so we shouldn't close it if it's not applied to HEAD - not if people expect it to be in the open release of Koha.



---- Additional Comments From drdrulm@yahoo.com 2010-02-17 18:28:19 ----

OK, I created and sent a patch to Galen for this w/ the same code (almost) we are running inside our library SMFPL.org.

-Darrell Ulm



---- Additional Comments From gmcharlt@gmail.com 2010-02-18 14:26:46 ----

Pushed Darrell Ulm's patch to HEAD.  Please test and close.



---- Additional Comments From mdhafen@tech.washk12.org 2010-02-18 21:46:51 ----

I've tested and it seems good.  The bug is assigned to Owen, but I'm going to mark it closed anyway.  Hope that's ok.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-20 23:38 UTC  ---

This bug was previously known as _bug_ 1080 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1080
Imported an attachment (id=53)
Imported an attachment (id=54)
Imported an attachment (id=55)
Imported an attachment (id=56)

Actual time not defined. Setting to 0.0
CC member daz-koha@zzzurn.com does not have an account here
CC member debra.denault@liblime.com does not have an account here
CC member drdrulm@yahoo.com does not have an account here
The original submitter of attachment 53 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 54 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 55 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 56 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.