Bug 10809 - use template branches plugin in serials search
Summary: use template branches plugin in serials search
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Fridolin Somers
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-30 13:18 UTC by Fridolin Somers
Modified: 2015-06-04 23:24 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10809 - use template branches plugin in serials search (2.83 KB, patch)
2013-08-30 13:22 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 10809 - use template branches plugin in serials search (2.86 KB, patch)
2013-10-17 09:38 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 10809 - use template branches plugin in serials search (2.95 KB, patch)
2013-11-07 14:16 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-08-30 13:18:35 UTC
In serials-search.pl, branch name is computed using branch code and then passed to template.
There is a new template plugin now for this : Koha::Template::Plugin::Branches.
Comment 1 Fridolin Somers 2013-08-30 13:22:15 UTC Comment hidden (obsolete)
Comment 2 cedric.vita 2013-09-19 08:00:06 UTC
I'm not sure I understood the patch. Is it possible to have information supplements.

thank you
Comment 3 Fridolin Somers 2013-09-19 14:14:30 UTC
This is a patch for better layers abstraction.
Actually, the branche name is computed from code in Perl (controler layer) :
  $subscription->{branchname} = GetBranchName ( $subscription->{branchcode} );
But this branch name is only for visual effect (UI layer), so computing in the template is much better.
Comment 4 I'm just a bot 2013-09-24 05:45:19 UTC
Patch applied cleanly, go forth and signoff
Comment 5 Biblibre Sandboxes 2013-10-17 09:38:14 UTC
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Comment 6 Biblibre Sandboxes 2013-10-17 09:38:30 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2013-11-07 14:16:57 UTC
Created attachment 22779 [details] [review]
Bug 10809 - use template branches plugin in serials search

In serials-search.pl, branch name is computed using branch code and then passed to template.

This patch uses the new template plugin now for this : Koha::Template::Plugin::Branches.

Test plan :
- Go to serials search
- Perform a search that returns at least an open an a closed subscription having a branch defined
=> The branch name is displayed in "Library" column

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2013-11-07 14:17:30 UTC
Simple patch, works as expected.
Marked as Passed QA.
Comment 9 Galen Charlton 2013-11-21 15:22:13 UTC
Pushed to master.  Thanks, Fridolin!
Comment 10 Fridolin Somers 2013-12-13 07:41:06 UTC
This patch has been pushed to 3.14.x, will be in 3.14.1
Comment 11 Tomás Cohen Arazi 2013-12-16 13:36:38 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Fridolin!