In serials-search.pl, branch name is computed using branch code and then passed to template. There is a new template plugin now for this : Koha::Template::Plugin::Branches.
Created attachment 20739 [details] [review] Bug 10809 - use template branches plugin in serials search See commit message. Very trivial patch
I'm not sure I understood the patch. Is it possible to have information supplements. thank you
This is a patch for better layers abstraction. Actually, the branche name is computed from code in Perl (controler layer) : $subscription->{branchname} = GetBranchName ( $subscription->{branchcode} ); But this branch name is only for visual effect (UI layer), so computing in the template is much better.
Patch applied cleanly, go forth and signoff
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Created attachment 22024 [details] [review] Bug 10809 - use template branches plugin in serials search In serials-search.pl, branch name is computed using branch code and then passed to template. This patch uses the new template plugin now for this : Koha::Template::Plugin::Branches. Test plan : - Go to serials search - Perform a search that returns at least an open an a closed subscription having a branch defined => The branch name is displayed in "Library" column Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Created attachment 22779 [details] [review] Bug 10809 - use template branches plugin in serials search In serials-search.pl, branch name is computed using branch code and then passed to template. This patch uses the new template plugin now for this : Koha::Template::Plugin::Branches. Test plan : - Go to serials search - Perform a search that returns at least an open an a closed subscription having a branch defined => The branch name is displayed in "Library" column Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Simple patch, works as expected. Marked as Passed QA.
Pushed to master. Thanks, Fridolin!
This patch has been pushed to 3.14.x, will be in 3.14.1
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Fridolin!