Bug 10829 - Browse across pages breaks for authority searches
Summary: Browse across pages breaks for authority searches
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
: 7898 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-09-05 14:46 UTC by Martin Renvoize
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10829 - Browse across pages breaks for authority searches (2.25 KB, patch)
2013-09-05 14:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 10829 - Browse across pages breaks for authority searches (2.31 KB, patch)
2013-10-11 13:18 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 10829 - Browse across pages breaks for authority searches (2.42 KB, patch)
2013-10-23 13:21 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2013-09-05 14:46:31 UTC
OK.. this one was hard to replicate, even harder to trace/debug, but relatively simple to fix!

Test plan
1. Do an authority search in the OPAC (A search for 'an:49' perhaps.. that should bring up results for authority number 49, hopefully there are multiple pages of results, if not try again and find one that gives you multiple pages of results)
2. Click the final result on any page of results (there must be more results to follow for this to work)
3. Try clicking the 'Next' button in the 'Browse results' pane on the right of the page.
4. It should take you to the next result in the search list (i.e the first result from the next page of results)  Double check it is correct, we found that it was often not.

5. Apply patch and run same process, this time you should get the correct paging.
Comment 1 Martin Renvoize 2013-09-05 14:53:28 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2013-09-05 17:54:12 UTC
*** Bug 7898 has been marked as a duplicate of this bug. ***
Comment 3 I'm just a bot 2013-09-29 05:52:24 UTC
Patch applied cleanly, go forth and signoff
Comment 4 Biblibre Sandboxes 2013-10-11 13:18:11 UTC
Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com>
Comment 5 Biblibre Sandboxes 2013-10-11 13:18:28 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-10-23 13:21:05 UTC
Created attachment 22314 [details] [review]
Bug 10829 - Browse across pages breaks for authority searches

Test plan
1. Do an authority search in the OPAC (A search for 'an:49' perhaps..
that should bring up results for authority number 49, hopefully there
are multiple pages of results, if not try again and find one that
gives you multiple pages of results)
2. Click the final result on any page of results (there must be more
results to follow for this to work)
3. Try clicking the 'Next' button in the 'Browse results' pane on
the right of the page.
4. It should take you to the next result in the search list (i.e
the first result from the next page of results) - Double check it is
correct, we found that it was often not.

5. Apply patch and run same process, this time you should get the
correct paging.

Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I reproduce the issue and I confirm this patch fixes it!
Comment 7 Galen Charlton 2013-10-23 15:04:40 UTC
Good catch.  Pushed to master; thanks, Martin!

Also, this is an object lesson in the utility of named parameters.
Comment 8 Tomás Cohen Arazi 2013-12-05 15:16:16 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Martin!