OK.. this one was hard to replicate, even harder to trace/debug, but relatively simple to fix! Test plan 1. Do an authority search in the OPAC (A search for 'an:49' perhaps.. that should bring up results for authority number 49, hopefully there are multiple pages of results, if not try again and find one that gives you multiple pages of results) 2. Click the final result on any page of results (there must be more results to follow for this to work) 3. Try clicking the 'Next' button in the 'Browse results' pane on the right of the page. 4. It should take you to the next result in the search list (i.e the first result from the next page of results) Double check it is correct, we found that it was often not. 5. Apply patch and run same process, this time you should get the correct paging.
Created attachment 20803 [details] [review] Bug 10829 - Browse across pages breaks for authority searches
*** Bug 7898 has been marked as a duplicate of this bug. ***
Patch applied cleanly, go forth and signoff
Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com>
Created attachment 21965 [details] [review] Bug 10829 - Browse across pages breaks for authority searches Test plan 1. Do an authority search in the OPAC (A search for 'an:49' perhaps.. that should bring up results for authority number 49, hopefully there are multiple pages of results, if not try again and find one that gives you multiple pages of results) 2. Click the final result on any page of results (there must be more results to follow for this to work) 3. Try clicking the 'Next' button in the 'Browse results' pane on the right of the page. 4. It should take you to the next result in the search list (i.e the first result from the next page of results) - Double check it is correct, we found that it was often not. 5. Apply patch and run same process, this time you should get the correct paging. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com>
Created attachment 22314 [details] [review] Bug 10829 - Browse across pages breaks for authority searches Test plan 1. Do an authority search in the OPAC (A search for 'an:49' perhaps.. that should bring up results for authority number 49, hopefully there are multiple pages of results, if not try again and find one that gives you multiple pages of results) 2. Click the final result on any page of results (there must be more results to follow for this to work) 3. Try clicking the 'Next' button in the 'Browse results' pane on the right of the page. 4. It should take you to the next result in the search list (i.e the first result from the next page of results) - Double check it is correct, we found that it was often not. 5. Apply patch and run same process, this time you should get the correct paging. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I reproduce the issue and I confirm this patch fixes it!
Good catch. Pushed to master; thanks, Martin! Also, this is an object lesson in the utility of named parameters.
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Martin!