Bug 10837 - Exporting serial claims does not work if no notice defined
Summary: Exporting serial claims does not work if no notice defined
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-07 01:24 UTC by Harsha
Modified: 2015-06-04 23:30 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Serials claims (62.88 KB, image/png)
2013-09-10 15:30 UTC, Jonathan Druart
Details
No check boxes (128.25 KB, image/jpeg)
2013-12-21 16:15 UTC, Harsha
Details
Bug 10837: Exporting serial claims does not work if no notice defined (2.03 KB, patch)
2013-12-23 09:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10837: Exporting serial claims does not work if no notice defined (2.08 KB, patch)
2014-03-07 18:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 10837: Exporting serial claims does not work if no notice defined (2.35 KB, patch)
2014-03-11 15:29 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Harsha 2013-09-07 01:24:37 UTC
Check boxes are missing in Serial > Claims > 'Late Selections list'' .

So I cannot  do "Exported selected items""  in my installations(v 3.12.0 and  3.12.3)

In Koha Demo( 3.12v), I have observed  same but Manual shows there are check boxes in 3.10v for the same task

I am new to KOHA and we, Open university, Sri Lanka testing  the system feasibility this is a drawback to us as  we have significant amount to Serials to manage. 

Thanks
Comment 1 Jonathan Druart 2013-09-10 15:30:49 UTC
Created attachment 20967 [details]
Serials claims

(In reply to Harsha from comment #0)
> Check boxes are missing in Serial > Claims > 'Late Selections list'' .
> 
> So I cannot  do "Exported selected items""  in my installations(v 3.12.0 and
> 3.12.3)
> 
> In Koha Demo( 3.12v), I have observed  same but Manual shows there are check
> boxes in 3.10v for the same task
> 
> I am new to KOHA and we, Open university, Sri Lanka testing  the system
> feasibility this is a drawback to us as  we have significant amount to
> Serials to manage. 
> 
> Thanks

Hello Harsha,
Could you detail the "Late Selections list" link?
Did you get a javascript error (using Firebug)?
Here my serial claims screen (on the master branch).
Comment 2 Katrin Fischer 2013-09-22 17:35:13 UTC
It looks like that for me too - Harsha, could you upload a screenshot of your installation?
Comment 3 Harsha 2013-12-21 16:15:04 UTC
Created attachment 23747 [details]
No check boxes

The check boxes are not availabe in 3.12 and 3.14

Path:  
http://YOURDOMAIN:PORT/cgi-bin/koha/serials/claims.pl   ( )Staff client

Please notice that the table and see no check boxes to  select.
 
Problem exist in  both  3.12 and 3.14v
Comment 4 Jonathan Druart 2013-12-23 09:03:54 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-12-23 09:06:41 UTC
(In reply to Harsha from comment #3)
Hello Harsha,
I suppose you don't have a claiming notice defined (claimissue).
The patch I proposed will display checkboxes even if the notice is not defined.
Comment 6 Kyle M Hall 2014-03-07 18:57:17 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2014-03-11 15:29:46 UTC
Created attachment 26119 [details] [review]
[PASSED QA] Bug 10837: Exporting serial claims does not work if no notice defined

On the serial claims page, it is possible to export (using a csv
profile) or claim 1+ serials.
The checkboxes are not shown if the claiming notice is not defined.
So it is not possible to export claims.

Test plan:
- delete your notice "claimissues"
- go on the serial claims page
- verify that you are able to export them as CSV

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This works as described and enables use of the export
funtionality even if you are not using the email notifications.
Exporting the serials will also set the claim date.
Passes QA script and tests.
Comment 8 Katrin Fischer 2014-03-11 15:31:30 UTC
There is one small thing I noticed - exporting the CSV file sets the claim counter, but you have to reload the page first for it to show up as downloading the CSV will not reload the page.
Comment 9 Galen Charlton 2014-03-11 16:51:58 UTC
Pushed to master.  Thanks, Jonathan!
Comment 10 Fridolin Somers 2014-05-27 15:56:49 UTC
Pushed to 3.14.x, will be in 3.14.07
Comment 11 Kyle M Hall 2014-06-06 13:57:26 UTC
Pushed to 3.12.x will be in 3.12.13