Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResults Sidebar %] from the opac-facets.inc file. This bug rectifies that problem. Test Plan: Confirm the problem =================== 1) Using version 3.12.4 package installation, set OPACResultsSidebar system preference to some text. 2) In the OPAC, search for something 3) In the facets list on the left, the text should appear. 4) Using master installation, set OPACResultsSidebar system preference to some text. 5) In the OPAC, search for something 6) The facets will not have the text, though viewing the source, there is an empty <div id="opacresultssidebar">. Correct the problem =================== 1) Apply the patch to the master system 2) In the OPAC, search again for something 3) The facets on the left will now have the text showing similar to the 3.12.4 version.
Created attachment 20845 [details] [review] Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %] Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResultsSidebar %] from the opac-facets.inc file. This bug rectifies that problem.
See the test plan in the first comment.
Created attachment 20991 [details] [review] Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %] Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResultsSidebar %] from the opac-facets.inc file. This bug rectifies that problem. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Is back! OPACResultsSidebar is back!
Created attachment 20999 [details] [review] Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %] Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResultsSidebar %] from the opac-facets.inc file. This bug rectifies that problem. Test Plan: Confirm the problem =================== 1) Using version 3.12.4 package installation, set OPACResultsSidebar system preference to some text. 2) In the OPAC, search for something 3) In the facets list on the left, the text should appear. 4) Using master installation, set OPACResultsSidebar system preference to some text. 5) In the OPAC, search for something 6) The facets will not have the text, though viewing the source, there is an empty <div id="opacresultssidebar">. Correct the problem =================== 1) Apply the patch to the master system 2) In the OPAC, search again for something 3) The facets on the left will now have the text showing similar to the 3.12.4 version Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Is back! OPACResultsSidebar is back!
Created attachment 21000 [details] [review] [PASSED QA] Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %] Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResultsSidebar %] from the opac-facets.inc file. This bug rectifies that problem. Test Plan: Confirm the problem =================== 1) Using version 3.12.4 package installation, set OPACResultsSidebar system preference to some text. 2) In the OPAC, search for something 3) In the facets list on the left, the text should appear. 4) Using master installation, set OPACResultsSidebar system preference to some text. 5) In the OPAC, search for something 6) The facets will not have the text, though viewing the source, there is an empty <div id="opacresultssidebar">. Correct the problem =================== 1) Apply the patch to the master system 2) In the OPAC, search again for something 3) The facets on the left will now have the text showing similar to the 3.12.4 version Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Is back! OPACResultsSidebar is back! Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Copied test plan from bug report into commit message. Template only change, works as expected.
Pushed to master. Thanks, Mark!