The serial module provide some status for serials. The missing status usually is not enough to describe the real status. We will suggest to add 4 new statuses for missing serials: never receipt, sold out, defective or lost.
Hi Jonathan, I think maybe check the status names with a native speaker? I couldn't make sense of defective :(
Created attachment 20936 [details] [review] Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never receipt, sold out, defective or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC.
(In reply to Katrin Fischer from comment #1) > Hi Jonathan, I think maybe check the status names with a native speaker? I > couldn't make sense of defective :( What do you propose? I had a choice with defective, faulty, flawed, cracked, etc. :)
What about damaged? And I think maybe Never received? But I think we really need a native speaker here :)
(In reply to Jonathan Druart from comment #3) > (In reply to Katrin Fischer from comment #1) > > Hi Jonathan, I think maybe check the status names with a native speaker? I > > couldn't make sense of defective :( > > What do you propose? I had a choice with defective, faulty, flawed, cracked, > etc. :) I see what you were looking for. How about "damaged"?
Created attachment 20958 [details] [review] Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC.
(In reply to Jared Camins-Esakov from comment #5) > > What do you propose? I had a choice with defective, faulty, flawed, cracked, > > etc. :) > > I see what you were looking for. How about "damaged"? Go for "damaged"! Last patch replaces "defective" with "damaged" and "never receipt" with "never received". Thank you Katrin & Jared!
Patch applied cleanly, go forth and signoff
Applying: Bug 10851: Serials - Add missing statuses Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt M koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging C4/Serials.pm Patch failed at 0001 Bug 10851: Serials - Add missing statuses The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Created attachment 22460 [details] [review] Bug 10851: Serials - Add missing statuses
Created attachment 22593 [details] [review] Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC.
(In reply to Jonathan Druart from comment #11) > Created attachment 22593 [details] [review] [review] > Bug 10851: Serials - Add missing statuses > > 4 new missing statuses is added by this patch: > never received, sold out, damaged or lost. > > These status have the same behavior than the simple Missing status. > > Test plan: > - Find a serial to claim. > - Modify the status of this serial with one of these new statuses. > - Try to find it with the "serials to claim" search. > - Verify that the status is displayed on the serial module pages and on > the OPAC. Hi I'm not sure to understand "sold out". I suppose you mean sold by the library to a user? If your goal was to make available for serial issues the same kind of status as we have for monographs, don't you think a "withdrawn" status could be interesting too? But maybe it is the idea behind "Missing (damaged)" ? Mathieu
Other points: If the meaning of "Missing" before your patch was always "never received", maybe you should rename "Missing" into "Missing (never received)", instead of creating a new one? If I understand well,the new statuses (except "never received") are supposed to be assigned to an issue that was fist received, and later disapeared from collection for some reason. I think this could be written somewhere, for ex. in online help. And the manual could be improved too. I think your patch could be useful, but I would prefer to have the opinion of somebody with a strong knowledge of Serial module. As I'm not at all an Serials expert, I don't feel confident enough to sign off or not. Mathieu
(In reply to mathieu saby from comment #12) > I'm not sure to understand "sold out". I suppose you mean sold by the > library to a user? No, the serial has not been received because it is sold out (ie. the publisher has sold all serials). (In reply to mathieu saby from comment #13) > Other points: > If the meaning of "Missing" before your patch was always "never received", > maybe you should rename "Missing" into "Missing (never received)", instead > of creating a new one? Maybe yes, maybe no. Maybe some libraries would like not to give a specific reason and to keep the generic one.
(In reply to Jonathan Druart from comment #14) > (In reply to mathieu saby from comment #12) > > I'm not sure to understand "sold out". I suppose you mean sold by the > > library to a user? > > No, the serial has not been received because it is sold out (ie. the > publisher has sold all serials). Ahh, it means "en rupture de stock". OK! I need to improve my english ;-)
Patch apply correctly (tested with all the new status in OPAC, "serials to claim" and on the serials module page)
Created attachment 24119 [details] [review] Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. Signed-off-by: Nicolas Bravais <nicolas.bravais@gmail.com>
Hi Jonathan, I have some fails in the QA script, but not sure what it means: FAIL C4/Serials.pm OK pod OK forbidden patterns FAIL valid Useless use of a constant (43) in void context Useless use of a constant (41) in void context Useless use of a constant (44) in void context Useless use of a constant (42) in void context Useless use of a constant (4) in void context OK critic Could you take a look?
Created attachment 24593 [details] [review] Bug 10851: FIX QA issues This patch fixes following warnings: FAIL C4/Serials.pm FAIL valid Useless use of a constant (43) in void context Useless use of a constant (41) in void context Useless use of a constant (44) in void context Useless use of a constant (42) in void context Useless use of a constant (4) in void context
I am sorry Jonathan, but there is a problem: - I have a subscription with 3 issues: - Arrived - Missing (sold out) - Expected When I go to the staff detail page, 2 issues are shown in the subscription tab. Only the "Arrived" status displays, the other status that should be "Missing (sold out)" is empty. On the OPAC detail page the display is ok.
Everything else I checked so far was ok, copying my testing notes here for later use :) Checked: - Receiving issues, setting and unsetting new status - Display on serial summary page - Display on subscription detail page, issues tab - Display on OPAC and staff detail pages, subscription tab OPAC: ok Staff: NOT OK - Missing status not shown - Claiming issues, filtering and status display
Created attachment 24736 [details] [review] Bug 10851: (follow-up) FIX bad c/p (variable name) In catalogue.detail.tt, a wrong variable loop was used. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(In reply to Katrin Fischer from comment #20) > When I go to the staff detail page, 2 issues are shown in the subscription > tab. > Only the "Arrived" status displays, the other status that should be "Missing > (sold out)" is empty. On the OPAC detail page the display is ok. Hi Katrin, I used a bad variable name, sorry. It should be fixed with the follow-up.
Created attachment 24987 [details] [review] [PASSED QA] Bug 10851: Serials - Add missing statuses 4 new missing statuses is added by this patch: never received, sold out, damaged or lost. These status have the same behavior than the simple Missing status. Test plan: - Find a serial to claim. - Modify the status of this serial with one of these new statuses. - Try to find it with the "serials to claim" search. - Verify that the status is displayed on the serial module pages and on the OPAC. Signed-off-by: Nicolas Bravais <nicolas.bravais@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 24988 [details] [review] [PASSED QA] Bug 10851: FIX QA issues This patch fixes following warnings: FAIL C4/Serials.pm FAIL valid Useless use of a constant (43) in void context Useless use of a constant (41) in void context Useless use of a constant (44) in void context Useless use of a constant (42) in void context Useless use of a constant (4) in void context Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 24989 [details] [review] [PASSED QA] Bug 10851: (follow-up) FIX bad c/p (variable name) In catalogue.detail.tt, a wrong variable loop was used. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> APatches pass QA script and tests. Additional tests done: - Receiving issues, setting and unsetting new status - Display on serial summary page - Display on subscription detail page, issues tab - Display on OPAC and staff detail pages, subscription tab OPAC: ok Staff: ok - Claiming issues, filtering and status display
Pushed to master. Thanks, Jonathan!
I don't like the way serials.status uses magic numbers, so I've opened bug 11682. Comments welcome.
This enhancement introduced an issue, please see bug 11689. Patch coming soon.
*** Bug 11822 has been marked as a duplicate of this bug. ***