Bug 10851 - Add missing statuses
Summary: Add missing statuses
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
: 11822 (view as bug list)
Depends on:
Blocks: 11689
  Show dependency treegraph
 
Reported: 2013-09-10 11:39 UTC by Jonathan Druart
Modified: 2014-12-07 20:07 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10851: Serials - Add missing statuses (17.79 KB, patch)
2013-09-10 12:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10851: Serials - Add missing statuses (17.78 KB, patch)
2013-09-10 13:37 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10851: Serials - Add missing statuses (18.26 KB, patch)
2013-10-28 08:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10851: Serials - Add missing statuses (18.35 KB, patch)
2013-10-30 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10851: Serials - Add missing statuses (18.41 KB, patch)
2014-01-10 12:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10851: FIX QA issues (1.86 KB, patch)
2014-01-21 09:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10851: (follow-up) FIX bad c/p (variable name) (1.90 KB, patch)
2014-01-27 09:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 10851: Serials - Add missing statuses (18.46 KB, patch)
2014-02-02 16:44 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10851: FIX QA issues (1.92 KB, patch)
2014-02-02 16:44 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10851: (follow-up) FIX bad c/p (variable name) (2.29 KB, patch)
2014-02-02 16:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-09-10 11:39:58 UTC
The serial module provide some status for serials.
The missing status usually is not enough to describe the real status.
We will suggest to add 4 new statuses for missing serials: never receipt, sold out, defective or lost.
Comment 1 Katrin Fischer 2013-09-10 12:00:12 UTC
Hi Jonathan, I think maybe check the status names with a native speaker? I couldn't make sense of defective :(
Comment 2 Jonathan Druart 2013-09-10 12:00:53 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-09-10 12:03:32 UTC
(In reply to Katrin Fischer from comment #1)
> Hi Jonathan, I think maybe check the status names with a native speaker? I
> couldn't make sense of defective :(

What do you propose? I had a choice with defective, faulty, flawed, cracked, etc. :)
Comment 4 Katrin Fischer 2013-09-10 12:05:56 UTC
What about damaged?
And I think maybe Never received?

But I think we really need a native speaker here :)
Comment 5 Jared Camins-Esakov 2013-09-10 12:08:39 UTC
(In reply to Jonathan Druart from comment #3)
> (In reply to Katrin Fischer from comment #1)
> > Hi Jonathan, I think maybe check the status names with a native speaker? I
> > couldn't make sense of defective :(
> 
> What do you propose? I had a choice with defective, faulty, flawed, cracked,
> etc. :)

I see what you were looking for. How about "damaged"?
Comment 6 Jonathan Druart 2013-09-10 13:37:40 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2013-09-10 13:39:03 UTC
(In reply to Jared Camins-Esakov from comment #5)
> > What do you propose? I had a choice with defective, faulty, flawed, cracked,
> > etc. :)
> 
> I see what you were looking for. How about "damaged"?

Go for "damaged"!
Last patch replaces "defective" with "damaged" and "never receipt" with "never received".
Thank you Katrin & Jared!
Comment 8 I'm just a bot 2013-09-29 05:56:10 UTC
Patch applied cleanly, go forth and signoff
Comment 9 I'm just a bot 2013-10-27 06:25:42 UTC
Applying: Bug 10851: Serials - Add missing statuses
Using index info to reconstruct a base tree...
M	C4/Serials.pm
M	koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
M	koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
M	koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
M	koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Auto-merging C4/Serials.pm
Patch failed at 0001 Bug 10851: Serials - Add missing statuses
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Comment 10 Jonathan Druart 2013-10-28 08:41:16 UTC Comment hidden (obsolete)
Comment 11 Jonathan Druart 2013-10-30 13:57:50 UTC Comment hidden (obsolete)
Comment 12 Mathieu Saby 2013-11-17 14:16:22 UTC
(In reply to Jonathan Druart from comment #11)
> Created attachment 22593 [details] [review] [review]
> Bug 10851: Serials - Add missing statuses
> 
> 4 new missing statuses is added by this patch:
> never received, sold out, damaged or lost.
> 
> These status have the same behavior than the simple Missing status.
> 
> Test plan:
> - Find a serial to claim.
> - Modify the status of this serial with one of these new statuses.
> - Try to find it with the "serials to claim" search.
> - Verify that the status is displayed on the serial module pages and on
>   the OPAC.

Hi
I'm not sure to understand "sold out". I suppose you mean sold by the library to a user?
If your goal was to make available for serial issues the same kind of status as we have for monographs, don't you think a "withdrawn" status could be interesting too? But maybe it is the idea behind "Missing (damaged)" ?

Mathieu
Comment 13 Mathieu Saby 2013-11-17 14:31:58 UTC
Other points:
If the meaning of "Missing" before your patch was always "never received", maybe you should rename "Missing" into "Missing (never received)", instead of creating a new one?

If I understand well,the new statuses (except "never received") are supposed to be assigned to an issue that was fist received, and later disapeared from collection for some reason.
I think this could be written somewhere, for ex. in online help. And the manual could be improved too.

I think your patch could be useful, but I would prefer to have the opinion of somebody with a strong knowledge of Serial module.
As I'm not at all an Serials expert, I don't feel confident enough to sign off or not.

Mathieu
Comment 14 Jonathan Druart 2013-11-18 10:41:14 UTC
(In reply to mathieu saby from comment #12)
> I'm not sure to understand "sold out". I suppose you mean sold by the
> library to a user?

No, the serial has not been received because it is sold out (ie. the publisher has sold all serials).

(In reply to mathieu saby from comment #13)
> Other points:
> If the meaning of "Missing" before your patch was always "never received",
> maybe you should rename "Missing" into "Missing (never received)", instead
> of creating a new one?

Maybe yes, maybe no. Maybe some libraries would like not to give a specific reason and to keep the generic one.
Comment 15 Mathieu Saby 2013-11-18 10:45:03 UTC
(In reply to Jonathan Druart from comment #14)
> (In reply to mathieu saby from comment #12)
> > I'm not sure to understand "sold out". I suppose you mean sold by the
> > library to a user?
> 
> No, the serial has not been received because it is sold out (ie. the
> publisher has sold all serials).


Ahh, it means "en rupture de stock". OK! I need to improve my english ;-)
Comment 16 nicolas 2014-01-10 10:54:15 UTC
Patch apply correctly
(tested with all the new status in OPAC, "serials to claim" and on the serials module page)
Comment 17 Jonathan Druart 2014-01-10 12:17:49 UTC Comment hidden (obsolete)
Comment 18 Katrin Fischer 2014-01-21 05:30:52 UTC
Hi Jonathan, I have some fails in the QA script, but not sure what it means:

 FAIL	C4/Serials.pm
   OK	  pod
   OK	  forbidden patterns
   FAIL	  valid
		Useless use of a constant (43) in void context 
		Useless use of a constant (41) in void context 
		Useless use of a constant (44) in void context 
		Useless use of a constant (42) in void context 
		Useless use of a constant (4) in void context 
   OK	  critic

Could you take a look?
Comment 19 Jonathan Druart 2014-01-21 09:10:28 UTC Comment hidden (obsolete)
Comment 20 Katrin Fischer 2014-01-25 10:44:55 UTC
I am sorry Jonathan, but there is a problem:

- I have a subscription with 3 issues:
  - Arrived
  - Missing (sold out)
  - Expected

When I go to the staff detail page, 2 issues are shown in the subscription tab.
Only the "Arrived" status displays, the other status that should be "Missing (sold out)" is empty. On the OPAC detail page the display is ok.
Comment 21 Katrin Fischer 2014-01-25 10:48:10 UTC
Everything else I checked so far was ok, copying my testing notes here for later use :)

Checked:
- Receiving issues, setting and unsetting new status
- Display on serial summary page
- Display on subscription detail page, issues tab
- Display on OPAC and staff detail pages, subscription tab
    OPAC: ok     
    Staff: NOT OK - Missing status not shown
- Claiming issues, filtering and status display
Comment 22 Jonathan Druart 2014-01-27 09:17:02 UTC Comment hidden (obsolete)
Comment 23 Jonathan Druart 2014-01-27 09:18:02 UTC
(In reply to Katrin Fischer from comment #20)
> When I go to the staff detail page, 2 issues are shown in the subscription
> tab.
> Only the "Arrived" status displays, the other status that should be "Missing
> (sold out)" is empty. On the OPAC detail page the display is ok.

Hi Katrin,
I used a bad variable name, sorry.
It should be fixed with the follow-up.
Comment 24 Katrin Fischer 2014-02-02 16:44:08 UTC
Created attachment 24987 [details] [review]
[PASSED QA] Bug 10851: Serials - Add missing statuses

4 new missing statuses is added by this patch:
never received, sold out, damaged or lost.

These status have the same behavior than the simple Missing status.

Test plan:
- Find a serial to claim.
- Modify the status of this serial with one of these new statuses.
- Try to find it with the "serials to claim" search.
- Verify that the status is displayed on the serial module pages and on
  the OPAC.

Signed-off-by: Nicolas Bravais <nicolas.bravais@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 25 Katrin Fischer 2014-02-02 16:44:25 UTC
Created attachment 24988 [details] [review]
[PASSED QA] Bug 10851: FIX QA issues

This patch fixes following warnings:

 FAIL   C4/Serials.pm
   FAIL   valid
        Useless use of a constant (43) in void context
        Useless use of a constant (41) in void context
        Useless use of a constant (44) in void context
        Useless use of a constant (42) in void context
        Useless use of a constant (4) in void context

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 26 Katrin Fischer 2014-02-02 16:44:36 UTC
Created attachment 24989 [details] [review]
[PASSED QA] Bug 10851: (follow-up) FIX bad c/p (variable name)

In catalogue.detail.tt, a wrong variable loop was used.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
APatches pass QA script and tests.
Additional tests done:
- Receiving issues, setting and unsetting new status
- Display on serial summary page
- Display on subscription detail page, issues tab
- Display on OPAC and staff detail pages, subscription tab
    OPAC: ok
    Staff: ok
- Claiming issues, filtering and status display
Comment 27 Galen Charlton 2014-02-04 17:49:40 UTC
Pushed to master.  Thanks, Jonathan!
Comment 28 Galen Charlton 2014-02-04 17:58:10 UTC
I don't like the way serials.status uses magic numbers, so I've opened bug 11682.  Comments welcome.
Comment 29 Jonathan Druart 2014-02-05 10:27:33 UTC
This enhancement introduced an issue, please see bug 11689.
Patch coming soon.
Comment 30 Frédérick Capovilla 2014-03-17 21:23:37 UTC
*** Bug 11822 has been marked as a duplicate of this bug. ***