Bug 10878 - Display856uAsImage works in Results pages, can remove caveat text from system preference.
Summary: Display856uAsImage works in Results pages, can remove caveat text from system...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-12 16:06 UTC by Doug Dearden
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 10878: Correct Display856uAsImage pref description (3.48 KB, patch)
2014-11-09 21:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 10878: Correct Display856uAsImage pref description (3.54 KB, patch)
2014-11-10 05:44 UTC, Chris Cormack
Details | Diff | Splinter Review
[Passed QA] Bug 10878: Correct Display856uAsImage pref description (3.62 KB, patch)
2014-11-12 08:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Dearden 2013-09-12 16:06:07 UTC
On the Staff Client Preferences page the option for Display856uAsImage has the text "(for future use, Results XSLT not functional at this time)" in two of the possible settings - Results and Both.  Sometime before 3.12.4 the Results XSLT page for the Staff Client was fixed and now works in the marc21 format, and will display 856u fields as images providing the other requirements are met (856q field populated correctly and XSLT preference turned on).  The normarc and unimarc may not work in both detail and results, there is already a bug open to correct the normarc.  However, I think the caveat text can be removed from this preference as it is working for marc21 at this time.
Comment 1 Katrin Fischer 2014-11-09 21:29:31 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-11-10 05:44:26 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize (ashimema) 2014-11-12 08:02:37 UTC
Created attachment 33472 [details] [review]
[Passed QA] Bug 10878: Correct Display856uAsImage pref description

Removes note about Display856uAsImage not working on
the OPAC result page.

To test:
- catalog a record with 856$u = URL to an image, $q = img
- turn on the system preference Display856uAsImage
- check that the pref description makes sense and is correct
  - the warning about the pref not working on result pages
    has been removed
- make sure your record has been reindexed by Zebra
- verifiy the image indeed displays on the result page
  in the bootstrap catalog.

Note: The height=100 doesn't work in the Boostrap catalog,
so the images display in their original size. Will file
a separate bug for this.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2014-11-12 08:03:00 UTC
Agree, patch is good... passing qa
Comment 5 Tomás Cohen Arazi (tcohen) 2014-11-17 00:23:40 UTC
Patch pushed to master.

Thanks Katrin!