The OverDrive collection search considers the option to be enabled if both OverDriveClientKey and OverDriveClientSecret are populated in system preferences. I think the check should also include OverDriveLibraryID since the search will fail without it.
Created attachment 95584 [details] [review] Bug 10879: OverDrive should check for OverDriveLibraryID before performing search This patch modifies the OPAC search results template to check for three populated system preferences before performing an OverDrive search: OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret. Previously OverDriveLibraryID was not checked, but without it the interface reports an error performing the search. To test you must have credentials for the OverDrive API as defined in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID system preferences. - With OverDriveLibraryID defined, the catalog search results page in the OPAC should show a link to results in the library's OverDrive collection. - With no value in the OverDriveLibraryID preference the catalog search page should not show any message about an OverDrive collection.
Created attachment 98191 [details] [review] Bug 10879: OverDrive should check for OverDriveLibraryID before performing search This patch modifies the OPAC search results template to check for three populated system preferences before performing an OverDrive search: OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret. Previously OverDriveLibraryID was not checked, but without it the interface reports an error performing the search. To test you must have credentials for the OverDrive API as defined in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID system preferences. - With OverDriveLibraryID defined, the catalog search results page in the OPAC should show a link to results in the library's OverDrive collection. - With no value in the OverDriveLibraryID preference the catalog search page should not show any message about an OverDrive collection. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 98363 [details] [review] Bug 10879: OverDrive should check for OverDriveLibraryID before performing search This patch modifies the OPAC search results template to check for three populated system preferences before performing an OverDrive search: OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret. Previously OverDriveLibraryID was not checked, but without it the interface reports an error performing the search. To test you must have credentials for the OverDrive API as defined in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID system preferences. - With OverDriveLibraryID defined, the catalog search results page in the OPAC should show a link to results in the library's OverDrive collection. - With no value in the OverDriveLibraryID preference the catalog search page should not show any message about an OverDrive collection. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Trusting Owen and Lucas to have tested with OverDrive - small template change, reads well, should have no side effects.
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
backported to 19.05.x for 19.05.08