Bug 10884 - Circulation table: odd behavior on checkboxes
Summary: Circulation table: odd behavior on checkboxes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 9294
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-13 14:26 UTC by Jonathan Druart
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10884: circulation table: fix odd behavior on checkboxes (1.92 KB, patch)
2013-09-13 14:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10884: circulation table: fix odd behavior on checkboxes (2.02 KB, patch)
2013-09-25 16:54 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 10884: circulation table: fix odd behavior on checkboxes (2.35 KB, patch)
2013-10-05 20:05 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-09-13 14:26:53 UTC
To reproduce:
- go on a circulation page with several checkouts.
- click on the check in cb
- click on the export cb
- click on the export cell (not the cb directly)
- click on the export cb
- click on the check in cb
- click on the export cell (not the cb directly)

The expected behavior is: the renew and check in cb should work as radio button, without affect the export cb.
Comment 1 Jonathan Druart 2013-09-13 14:30:24 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-09-18 11:05:55 UTC
Applying: Bug 10884: circulation table: fix odd behavior on checkboxes
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 10884: circulation table: fix odd behavior on checkboxes
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Comment 3 Jonathan Druart 2013-09-18 12:42:19 UTC
(In reply to I'm just a bot from comment #2)
Depend on bug 9294
Comment 4 Owen Leonard 2013-09-25 16:54:07 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-10-05 20:05:09 UTC
Created attachment 21826 [details] [review]
[PASSED QA] Bug 10884: circulation table: fix odd behavior on checkboxes

Test plan:
Play with renew, check in and export checkboxes.
The expected behavior is: the renew and check in cb should work as radio
button, without affecting the export cb.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Template changes only.
Amended test plan:
* Create a CSV profile under Tools > CSV profiles
* Add CSV profile to system preference ExportWithCsvProfile

1) Check export checkbox
2) Check check in for same item
3) Switch to Renew

The export checkbox should not get unchecked when switching
between renew and check in.
Comment 6 Galen Charlton 2013-10-17 16:50:09 UTC
Pushed to master.  Thanks, Jonathan!

I did discover a bug when clicking the 'select all' link in the export column; this was not introduced by this patch, so I'll just open a new bug.
Comment 7 Tomás Cohen Arazi 2013-12-03 18:08:38 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Jonathan!