To reproduce: - go on a circulation page with several checkouts. - click on the check in cb - click on the export cb - click on the export cell (not the cb directly) - click on the export cb - click on the check in cb - click on the export cell (not the cb directly) The expected behavior is: the renew and check in cb should work as radio button, without affect the export cb.
Created attachment 21093 [details] [review] Bug 10884: circulation table: fix odd behavior on checkboxes Test plan: Play with renew, check in and export checkboxes. The expected behavior is: the renew and check in cb should work as radio button, without affecting the export cb.
Applying: Bug 10884: circulation table: fix odd behavior on checkboxes Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10884: circulation table: fix odd behavior on checkboxes The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
(In reply to I'm just a bot from comment #2) Depend on bug 9294
Created attachment 21455 [details] [review] [SIGNED-OFF] Bug 10884: circulation table: fix odd behavior on checkboxes Test plan: Play with renew, check in and export checkboxes. The expected behavior is: the renew and check in cb should work as radio button, without affecting the export cb. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 21826 [details] [review] [PASSED QA] Bug 10884: circulation table: fix odd behavior on checkboxes Test plan: Play with renew, check in and export checkboxes. The expected behavior is: the renew and check in cb should work as radio button, without affecting the export cb. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template changes only. Amended test plan: * Create a CSV profile under Tools > CSV profiles * Add CSV profile to system preference ExportWithCsvProfile 1) Check export checkbox 2) Check check in for same item 3) Switch to Renew The export checkbox should not get unchecked when switching between renew and check in.
Pushed to master. Thanks, Jonathan! I did discover a bug when clicking the 'select all' link in the export column; this was not introduced by this patch, so I'll just open a new bug.
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan!