Bug 10886 - Hide patron information in item history if intranetreadinghistory is set to not allow
Summary: Hide patron information in item history if intranetreadinghistory is set to n...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
: 10885 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-09-13 15:09 UTC by Danielle Elder
Modified: 2016-06-21 21:38 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10886: Hide patron's history if intranetreadinghistory is set to not allow (4.49 KB, patch)
2015-04-22 10:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
[Signed-off] Bug 10866: Hide patron's history if intranetreadinghistory is set to not allow (4.73 KB, patch)
2015-04-23 07:09 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 10866: Hide patron's history if intranetreadinghistory is set to not allow (4.80 KB, patch)
2015-04-23 09:29 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Danielle Elder 2013-09-13 15:09:57 UTC
When intranetreadinghistory system preference is set to not allow, the individual patron's history can not be viewed, but if you look at the item history, staff can still view patrons who have checked out that item.
Comment 1 Danielle Elder 2013-09-13 15:11:24 UTC
*** Bug 10885 has been marked as a duplicate of this bug. ***
Comment 2 Danielle Elder 2014-09-19 21:47:37 UTC
Comment from library partner.

FYI, I have added JQuery to remove column with the names.  Since it SHOULD anonymize all records for staff sake, it would make the entire column read Anonymous Patron.  Since that is the case, there really isn't any need for that column.

I would like to suggest that if the intranetreadinghistory is set, this column should be hidden.  Either that, or there should be a separate switch to hide the column.  It doesn't make a whole lot of sense to hide the information from the staff in one place, but show it in another.

Christopher
Comment 3 Jonathan Druart 2015-04-22 10:21:14 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2015-04-23 07:09:23 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2015-04-23 09:29:21 UTC
Created attachment 38396 [details] [review]
[PASSED QA] Bug 10866: Hide patron's history if intranetreadinghistory is set to not allow

If set to "not allow", the intranetreadinghistory pref prevent staff
members to access patron's checkout history.
But:
1/ The page is still accessible if you know the url
2/ The history can be consulted on the item history page

Test plan:
0/ Don't apply this patch
1/ Set the intranetreadinghistory to allow
2/ Go on a patron's checkout history page
3/ Open a new tab and go on a item's checkout history page
4/ Set the intranetreadinghistory to not allow
5/ Refresh both pages => no change
6/ Apply this patch
7/ Refresh both page.
On the first page, you should see a warning
On the other one, you should see that the patron column is not displayed
anymore.

Followed test plan, results were as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

http://bugs.koha-community.org/show_bug.cgi?id=10886
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Nice addition!
Comment 6 Tomás Cohen Arazi 2015-06-19 14:50:01 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 7 Chris Cormack 2015-06-29 09:40:15 UTC
Pushed to 3.20.x will be in 3.20.2
Comment 8 Liz Rea 2015-07-20 22:04:38 UTC
Pushed to 3.18.x will be in 3.18.09
Comment 9 Mason James 2015-07-25 10:39:43 UTC
Pushed to 3.16.x, will be in 3.16.13