Bug 10889 - wrong description for a column of biblio table in kohastructure.sql
Summary: wrong description for a column of biblio table in kohastructure.sql
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Galen Charlton
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-15 11:50 UTC by Mathieu Saby
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10889: fix comment describing biblioitems.serial (2.44 KB, patch)
2013-10-20 17:49 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 10889: fix comment describing biblioitems.serial (2.50 KB, patch)
2013-10-20 20:50 UTC, Joy Nelson
Details | Diff | Splinter Review
Bug 10889: fix comment describing biblioitems.serial (2.56 KB, patch)
2013-10-23 12:45 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-09-15 11:50:18 UTC
I don't know if it deserved to be reported. Maybe, if the description is used to generate tables in schemaspy.

For biblio table in kohastructure.sql, we have :

  `serial` tinyint(1) default NULL, -- foreign key, linking to the subscriptionid in the serial table


But serial field is not linking to the subscriptionid in the serial table. It contains 1 if the record is a serial.

M. Saby
Comment 1 Katrin Fischer 2013-09-15 11:59:33 UTC
Hm, I think that's only the case for UNIMARC currently, so maybe worth noting that too.
Comment 2 Katrin Fischer 2013-09-15 12:01:20 UTC
Hm, maybe that's not entirely true - I have 2 records marked with 1 in my database - but I am not sure when and how that is set? And I have way more serials and subscriptions.
Comment 3 Mathieu Saby 2013-09-15 12:29:34 UTC
What do you mean? In Marc21 Koha, this field is used as a foreign key??
That's not the case at all in Rennes 2 (value = 1 / 0 / null)
This should not be MARCflavordependant, so it deserves an other bug if Serials are not managed in Unimarc as in Marc21!

Mathieu
Comment 4 Mathieu Saby 2013-09-15 12:30:50 UTC
Oh, but it cannot be : The type Tinyint(1) cannot store a foreign key ;-)
Comment 5 Katrin Fischer 2013-09-15 12:57:23 UTC
nope, it's never a key, sorry for causing confusion. I just think that only UNIMARC really makes use of that field so far :)
Comment 6 Galen Charlton 2013-10-20 17:49:18 UTC Comment hidden (obsolete)
Comment 7 Joy Nelson 2013-10-20 20:50:11 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2013-10-23 12:45:08 UTC
Created attachment 22312 [details] [review]
Bug 10889: fix comment describing biblioitems.serial

biblioitems.serial is not a foreign key; it's a Boolean indicating
whether the biblio record is a serial, which in turn influences how
serial items are displayed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Galen Charlton 2013-10-23 14:14:07 UTC
Pushed to master.
Comment 10 Tomás Cohen Arazi 2013-12-05 15:19:04 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Galen!