I don't know if it deserved to be reported. Maybe, if the description is used to generate tables in schemaspy. For biblio table in kohastructure.sql, we have : `serial` tinyint(1) default NULL, -- foreign key, linking to the subscriptionid in the serial table But serial field is not linking to the subscriptionid in the serial table. It contains 1 if the record is a serial. M. Saby
Hm, I think that's only the case for UNIMARC currently, so maybe worth noting that too.
Hm, maybe that's not entirely true - I have 2 records marked with 1 in my database - but I am not sure when and how that is set? And I have way more serials and subscriptions.
What do you mean? In Marc21 Koha, this field is used as a foreign key?? That's not the case at all in Rennes 2 (value = 1 / 0 / null) This should not be MARCflavordependant, so it deserves an other bug if Serials are not managed in Unimarc as in Marc21! Mathieu
Oh, but it cannot be : The type Tinyint(1) cannot store a foreign key ;-)
nope, it's never a key, sorry for causing confusion. I just think that only UNIMARC really makes use of that field so far :)
Created attachment 22083 [details] [review] Bug 10889: fix comment describing biblioitems.serial biblioitems.serial is not a foreign key; it's a Boolean indicating whether the biblio record is a serial, which in turn influences how serial items are displayed. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 22109 [details] [review] Bug 10889: fix comment describing biblioitems.serial biblioitems.serial is not a foreign key; it's a Boolean indicating whether the biblio record is a serial, which in turn influences how serial items are displayed. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Created attachment 22312 [details] [review] Bug 10889: fix comment describing biblioitems.serial biblioitems.serial is not a foreign key; it's a Boolean indicating whether the biblio record is a serial, which in turn influences how serial items are displayed. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master.
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Galen!