Location facet in UNIMARC is void. In the code, it is build on 995$c, while location is store in 995$e (see record.abs). M. Saby
Created attachment 21114 [details] [review] [PATCH] Bug 10893: fix location facet in UNIMARC Location facet in UNIMARC is void. In the code, it is build on 995$c, while location is store in 995$e (see record.abs). This patch replace 995$c with 995$e in Koha.pm To test : 1. Use a UNIMARC Koha instance with ONE branch, and SEVERAL locations 2. Make a search in opac and staff interface : no location facet on the left side of the screen 3. apply the patch 4. Make the same search : location facets will be displayed
I've got a problem on sandbox. I dont see any location facets
Sandboxes have several branches, maybe that could explain. Or the locations are not defined in 995$e in sandboxes, I don't know. Let someone else try to test, and thank you for trying. Mathieu
I've made some modifications and erase the second branch. There is still nothing :/
I have had a similar problem last week when trying to demo the 'new' location facet. Maybe it's a more general problem?
Well, if my patch is not working, I will take an other look after Bug 10078 is pushed, as it deals with location too. What I can say in a sure way is that 995$c is not the standard location field, and it should be replaced with 995$e. Mathieu
Mathieu, could you test that the location facet shows up for you? My problem was it didn't show up for MARC21 - so totally unrelated to your fix that seems logical to me.
Patch applied cleanly, go forth and signoff
Created attachment 26912 [details] [review] Bug 10893: fix location facet in UNIMARC Location facet in UNIMARC is void. In the code, it is build on 995$c, while location is store in 995$e (see record.abs). This patch replace 995$c with 995$e in Koha.pm To test : 1. Use a UNIMARC Koha instance with ONE branch, and SEVERAL locations 2. Make a search in opac and staff interface : no location facet on the left side of the screen 3. apply the patch 4. Make the same search : location facets will be displayed NOTE: I, Mark Tompsett, rebased this. I confirmed that 995$c should be 995$e (wiki, Holdings_data_fields_(9xx) page) Also note that the code relocated based on bug 10078, causing the patch to not apply.
Created attachment 26913 [details] [review] [SIGNED OFF] Bug 10893: fix location facet in UNIMARC Location facet in UNIMARC is void. In the code, it is build on 995$c, while location is store in 995$e (see record.abs). This patch replace 995$c with 995$e in Koha.pm To test : 1. Use a UNIMARC Koha instance with ONE branch, and SEVERAL locations 2. Make a search in opac and staff interface : no location facet on the left side of the screen 3. apply the patch 4. Make the same search : location facets will be displayed NOTE: I, Mark Tompsett, rebased this. I confirmed that 995$c should be 995$e (wiki, Holdings_data_fields_(9xx) page) Also note that the code relocated based on bug 10078, causing the patch to not apply. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: The location facet did not appear in master, but after applying the patch, it did appear. Because of the code being moved, it is no longer affected by the branch count or singleBranchMode.
Thank Mark you for rebasing and signing off! Mathieu
Created attachment 26916 [details] [review] [PASSED QA] Bug 10893: fix location facet in UNIMARC Location facet in UNIMARC is void. In the code, it is build on 995$c, while location is store in 995$e (see record.abs). This patch replace 995$c with 995$e in Koha.pm To test : 1. Use a UNIMARC Koha instance with ONE branch, and SEVERAL locations 2. Make a search in opac and staff interface : no location facet on the left side of the screen 3. apply the patch 4. Make the same search : location facets will be displayed NOTE: I, Mark Tompsett, rebased this. I confirmed that 995$c should be 995$e (wiki, Holdings_data_fields_(9xx) page) Also note that the code relocated based on bug 10078, causing the patch to not apply. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: The location facet did not appear in master, but after applying the patch, it did appear. Because of the code being moved, it is no longer affected by the branch count or singleBranchMode. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes wrong subfield code for UNIMARC.
Pushed to master. Thanks, Mathieu!
Pushed to 3.14.x, will be in 3.14.12.