Bug 10907 - Showing the staff members name who managed a suggestion should be optional
Summary: Showing the staff members name who managed a suggestion should be optional
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-17 22:50 UTC by Katrin Fischer
Modified: 2014-12-07 20:07 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC (7.51 KB, patch)
2013-12-09 17:45 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC (7.78 KB, patch)
2013-12-22 20:26 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC (7.81 KB, patch)
2014-01-16 08:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-09-17 22:50:42 UTC
To test:
- Create some suggestons
- Manage (accept or reject) them from the intranet
- Check your patron account in the OPAC
- The list of suggestions shows the name of the staff member who managed the suggestion

I think this is critical and should be optional and handles on template level with a system preference.
Comment 1 Katrin Fischer 2013-12-09 17:45:08 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-12-22 20:26:11 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-01-16 08:19:45 UTC
Created attachment 24449 [details] [review]
Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC

The name of a staff member who managed a suggestion is shown in the
the OPAC if the new system preference OpacSuggestionManagedBy is set to
'Show'. This is also the default.

If the preference is set to 'Don't show' the staff members name
is not displayed and the column 'Managed by' in the table of
suggestions in the patron account is not displayed.

To test:
- Create a one or more suggestions
- 'Manage' them by accecpting or rejecting
- Go to your patron account and check that the staff member name is
  shown for your suggestions
- Apply patch, run database update
- Check the name is still shown
- Switch the preference to 'Don't show'
- Check the name is no longer shown and the table still displays
  correctly, but without the 'Managed by' column
- Repeat those tests for both bootstrap and prog theme!

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Works as advertised, the only little nitpick is you could just do
[% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %]

However you are following the custom in that file already, so that's
fine

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2014-01-16 08:20:20 UTC
Looks good to me. No koha-qa complaints.

Passed QA
Comment 5 Galen Charlton 2014-01-23 18:35:54 UTC
Pushed to master, along with a follow-up to repair table sorting.

Thanks, Katrin!
Comment 6 Jonathan Druart 2014-01-24 08:54:07 UTC
This king of patch could be done using the base offered by bug 10212.
It will avoid to create yasp.
Comment 7 Katrin Fischer 2014-01-24 08:57:42 UTC
I did this mostly thinking about data privacy as we have to use personalized accounts for each staff member. So JQuery/CSS was not enough to achieve the goal here and hide the information safely.
Comment 8 Jonathan Druart 2014-01-24 09:20:38 UTC
Yes sorry, you are right. I did not think about the data privacy problem.
Comment 9 Katrin Fischer 2014-01-24 09:23:06 UTC
Just trying to explain - I agree it's a pref for a small thing :)