You can delete a patron who has made suggestions without any warn. We should have a specific warn, especially if all suggestions are not yet available (deleting the patron will make impossible to send him an email when the book arrive). M. Saby
There comes the alert: "Are you sure you want to delete this patron? This cannot be undone." We could change it to something like: "Are you sure you want to delete this patron? All patron's details will be deleted including suggestions, blablabla. This cannot be undone." What would be a good alert text there?
Hm, I think maybe keep the suggestions, but just set the borrowernumber to 0 or 'anonymous' if that isn't the case yet?
(In reply to Katrin Fischer from comment #2) > Hm, I think maybe keep the suggestions, but just set the borrowernumber to 0 > or 'anonymous' if that isn't the case yet? I could guess the suggestions are kept already (I hope so). But If we delete a patron I think we cannot just delete the references to that Patron object, and leave all the data still in the system. If we want to keep some info like email address then we need to transfer it to the suggestion object. However, I don't see this as an important feature to implement (to keep the email address). In my opinion the warning message is enough.
I think having a warning about suggestions would be nice, but should not block deleting. Also, we should not send them an email after deleting - if the patron 'revokes' the library's right to process/store their data, it might not be well received to email them after deletion...
Created attachment 89360 [details] [review] Bug 10910: Add a warning when deleting a patron with pending suggestions
(In reply to Jonathan Druart from comment #5) > Created attachment 89360 [details] [review] [review] > Bug 10910: Add a warning when deleting a patron with pending suggestions Something like that? Should we also add a warning in the batch deletion tool?
(In reply to Jonathan Druart from comment #6) > (In reply to Jonathan Druart from comment #5) > > Created attachment 89360 [details] [review] [review] [review] > > Bug 10910: Add a warning when deleting a patron with pending suggestions > > Something like that? Should we also add a warning in the batch deletion tool? Yes, I think your patch looks good. I think having it on batch delete would be nice too, but could be handled in a separate bug.
Created attachment 103903 [details] [review] Bug 10910: Add a warning when deleting a patron with pending suggestions Test plan: From the OPAC, add a suggestion From the staff interface, try to delete the patron who created the suggestion => You get a warning message
Created attachment 104094 [details] [review] Bug 10910: Add a warning when deleting a patron with pending suggestions Test plan: From the OPAC, add a suggestion From the staff interface, try to delete the patron who created the suggestion => You get a warning message Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 104128 [details] [review] Bug 10910: Add a warning when deleting a patron with pending suggestions Test plan: From the OPAC, add a suggestion From the staff interface, try to delete the patron who created the suggestion => You get a warning message Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 104129 [details] [review] Bug 10910: (follow-up) Move the suggestions note with the other non-blocking notes To test: - Add a credit to the patron's account - Make sure they got a pending suggestion - Try to delete - Verify you notes for both as list items Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Joubu or Victor - I moved things around a bit as we already have notes for existing holds and an open credit. Could you have another look?
Created attachment 104237 [details] [review] Bug 10910: Add a warning when deleting a patron with pending suggestions Test plan: From the OPAC, add a suggestion From the staff interface, try to delete the patron who created the suggestion => You get a warning message Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 104238 [details] [review] Bug 10910: (follow-up) Move the suggestions note with the other non-blocking notes To test: - Add a credit to the patron's account - Make sure they got a pending suggestion - Try to delete - Verify you notes for both as list items Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Before: https://picat.drycat.fr/VIBbTcie.png After: https://picat.drycat.fr/BRfUuGCH.png Thanks cait! :)
Created attachment 105752 [details] [review] Bug 10910: Add a warning when deleting a patron with pending suggestions Test plan: From the OPAC, add a suggestion From the staff interface, try to delete the patron who created the suggestion => You get a warning message Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 105753 [details] [review] Bug 10910: (follow-up) Move the suggestions note with the other non-blocking notes To test: - Add a credit to the patron's account - Make sure they got a pending suggestion - Try to delete - Verify you notes for both as list items Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
enhancement, not backported to 19.11.x