Standard number is listed twice in advanced search, when more options are activated.
If I'm not wrong, line 120 of en/modules/opac-advsearch.tt must be soppressed.
Created attachment 26152 [details] [review] This patch removes the dupilcate "Standard Number" option under the more options of the opac advanced search.
To test: From the OPAC click on the "advanced search" option. Then on the advanced search page click on "more options" you will the see that "Standard number" is on the list twice. Apply Patch. Re-test and now only one option.
Hi Jesse, As agreed, I'm failing QA as the patch seems to add a number of new files: - showdiffmarc.pl - showdiffmarc.tt (these files also currently use tab instead of space as indentation). Let me know if I misunderstood. Best wishes, Alex
Created attachment 26167 [details] [review] Patch updated. Please re-test.
Created attachment 26173 [details] [review] Patch updated. Please re-test. http://bugs.koha-community.org/show_bug.cgi?id=10936 Signed-off-by: A. Sassmannshausen <alex.sassmannshausen@ptfs-europe.com>
*** Bug 11613 has been marked as a duplicate of this bug. ***
Please provide a correct commit message and a test plan. Marked as Failed QA.
Created attachment 26322 [details] [review] Bug 10936 - Standardnumber doubled up in Advanced search - more options Standard number is listed twice in advanced search, when more options are activated. Test Plan: In the OPAC click on the advanced search option, then click add more options. You will see the "Standard Number" option twice in the drop down menu.Then: Apply patch and the "Standard Number" option is correctly displayed once in the drop down menus.
Comment on attachment 26322 [details] [review] Bug 10936 - Standardnumber doubled up in Advanced search - more options Review of attachment 26322 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt @@ +84,2 @@ > [% END %] > <option value="sn">Standard number</option> I am sorry, but this won't work quite right. Let me try to explain: [% IF ( numbersphr) %] refers to the system preference OPACNumbersPreferPhrase. It switches the index, one time it's sn,phr and the other time it's sn. If you apply the current patch and set OPACNumbersPreferPhrase to 'use', the index will still show up twice, because the IF is true and there is another <option value="sn">Standard number</option> below the former IF-ELSE construct. If you delete this <option> instead, and keep the IF-ELSE as before, it should work alright. Hope that did make some kind of sense :)
Created attachment 26686 [details] [review] Bug 10936 This patch removes the dupilcate "Standard Number" option under the more options of the opac advanced search correctly following updates from Katrin.
I decided to attempt a grep: $ grep -l "Standard number" `find . -name "*.tt"` ./koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt ./koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt ./koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt This problem exists in: ./koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt Please attach a fix for prog as well. This will allow for back ports to previous versions. I changed this to a minor bug, not an enhancement. Please check the bug level in the future. Enhancement is the current default (BAD!!!!!).
Created attachment 26698 [details] [review] [SIGNED OFF] Bug 10936 - 'Standard number' doubled up in Advanced search This patch removes the dupilcate 'Standard number' option under the more options of the opac advanced search correctly following updates from Katrin. TEST PLAN --------- 1) Set opacthemes system preference to bootstrap 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
I have left this as 'Needs Signoff', since I'm waiting for a prog theme patch.
Created attachment 27192 [details] [review] Bug 10936 - Follow-up for Prog theme - Standardnumber doubled up in Advanced search - more options TEST PLAN --------- 1) Set opacthemes system preference to prog 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time
Created attachment 27744 [details] [review] [SIGNED-OFF] Bug 10936 - Follow-up for Prog theme - Standardnumber doubled up in Advanced search - more options TEST PLAN --------- 1) Set opacthemes system preference to prog 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described on prog theme, no more duplicate. No koha-qa errors
Created attachment 28284 [details] [review] [PASSED QA] Bug 10936 - 'Standard number' doubled up in Advanced search This patch removes the dupilcate 'Standard number' option under the more options of the opac advanced search correctly following updates from Katrin. TEST PLAN --------- 1) Set opacthemes system preference to bootstrap 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 28285 [details] [review] [PASSED QA] Bug 10936 - Follow-up for Prog theme - Standardnumber doubled up in Advanced search - more options TEST PLAN --------- 1) Set opacthemes system preference to prog 2) In OPAC, click 'Advanced search' 3) Click 'More options' 4) Check the Keywords dropdown for duplicate 'Standard number' 5) Apply patch 6) Refresh page, and make sure 'More options' is clicked still 7) Check the Keywords dropdown for duplicate 'Standard number' -- it's not this time Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described on prog theme, no more duplicate. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Pushed to master and 3.16.x. Thanks, Jesse and Marc!