When one checks in an item and uses the 'print and confirm' button to print a hold slip, the text printed out is only "reserve not found", with no information about the hold. This appears to be a regression caused by the patch for bug 9394.
Created attachment 21451 [details] [review] bug 10949: restore ability to successfully print hold slips This fixes a regression introduced by the patch for bug 9394 -- when printing a hold slip using the 'print and confirm' button, the slip would contain only the text 'reserve not found', not a full hold slip. This patch also adds a regression test. To test: [1] Check in an item that would fill a hold. Use the 'print and confirm button' to confirm the hold. [2] The printout will only contain text to the effect of 'reserve not found'. [3] Apply the patch. [4] Repeat step 1. This time, a full hold slip should be printed. [5] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 21453 [details] [review] [SIGNED-OFF] Bug 10949: restore ability to successfully print hold slips This fixes a regression introduced by the patch for bug 9394 -- when printing a hold slip using the 'print and confirm' button, the slip would contain only the text 'reserve not found', not a full hold slip. This patch also adds a regression test. To test: [1] Check in an item that would fill a hold. Use the 'print and confirm button' to confirm the hold. [2] The printout will only contain text to the effect of 'reserve not found'. [3] Apply the patch. [4] Repeat step 1. This time, a full hold slip should be printed. [5] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 21530 [details] [review] [PASSED QA] Bug 10949: restore ability to successfully print hold slips This fixes a regression introduced by the patch for bug 9394 -- when printing a hold slip using the 'print and confirm' button, the slip would contain only the text 'reserve not found', not a full hold slip. This patch also adds a regression test. To test: [1] Check in an item that would fill a hold. Use the 'print and confirm button' to confirm the hold. [2] The printout will only contain text to the effect of 'reserve not found'. [3] Apply the patch. [4] Repeat step 1. This time, a full hold slip should be printed. [5] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pass all tests, new and old, and QA script. Verified wrong and corrected behaviour. Note: Sometimes there will not be the message 'reserve not found' showing up, but hold information for a different record. This happens when there exists a reserve_id with the borrowernumber of the patron in question in your database.
Pushed to master.