Bug 10950 - Add pronoun field to patron record
Summary: Add pronoun field to patron record
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement with 20 votes (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30981 35599
  Show dependency treegraph
 
Reported: 2013-09-25 17:57 UTC by Kyle M Hall
Modified: 2024-03-25 13:49 UTC (History)
14 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/616
Text to go in the release notes:
This adds a new free text field 'pronouns' to the patron record. The pronouns also display prominently in the brief patron information section on the left side of the patron account pages.
Version(s) released in:
22.11.00


Attachments
Bug 10950: Database update (4.58 KB, patch)
2022-06-09 14:18 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Database update (4.58 KB, patch)
2022-06-09 14:22 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: API spec update (762 bytes, patch)
2022-06-09 14:26 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Schema update (2.67 KB, patch)
2022-06-09 14:34 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Add intranet/OPAC form fields (8.82 KB, patch)
2022-06-09 16:03 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Display pronouns field (4.09 KB, patch)
2022-06-09 16:25 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: API spec update (1.89 KB, patch)
2022-06-10 17:55 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: (follow-up) fix typo in kohastructure.sql (1.55 KB, patch)
2022-06-13 17:30 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Database update (4.64 KB, patch)
2022-06-14 08:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 10950: Schema update (2.74 KB, patch)
2022-06-14 08:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 10950: Add intranet/OPAC form fields (8.88 KB, patch)
2022-06-14 08:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 10950: Display pronouns field (4.16 KB, patch)
2022-06-14 08:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 10950: API spec update (1.95 KB, patch)
2022-06-14 08:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 10950: (follow-up) fix typo in kohastructure.sql (1.62 KB, patch)
2022-06-14 08:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 10950: (QA follow-up) Exec (548 bytes, patch)
2022-06-14 08:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 10950: Database update (4.64 KB, patch)
2022-08-22 15:30 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Schema update (2.72 KB, patch)
2022-08-22 15:30 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Add intranet/OPAC form fields (9.08 KB, patch)
2022-08-22 15:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Display pronouns field (4.39 KB, patch)
2022-08-22 15:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: API spec update (1.95 KB, patch)
2022-08-22 15:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: (follow-up) fix typo in kohastructure.sql (1.62 KB, patch)
2022-08-22 15:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: (QA follow-up) Exec (548 bytes, patch)
2022-08-22 15:31 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Database update (4.70 KB, patch)
2022-08-22 17:16 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: Schema update (2.78 KB, patch)
2022-08-22 17:16 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: Add intranet/OPAC form fields (9.14 KB, patch)
2022-08-22 17:16 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: Display pronouns field (4.45 KB, patch)
2022-08-22 17:16 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: API spec update (2.01 KB, patch)
2022-08-22 17:16 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: (follow-up) fix typo in kohastructure.sql (1.68 KB, patch)
2022-08-22 17:16 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: (QA follow-up) Exec (608 bytes, patch)
2022-08-22 17:16 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form (1.59 KB, patch)
2022-08-28 11:41 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 10950: (follow-up) Change display of pronoun fields (5.71 KB, patch)
2022-08-29 22:26 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 10950: Database update (4.76 KB, patch)
2022-08-30 17:00 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: Schema update (2.84 KB, patch)
2022-08-30 17:00 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: Add intranet/OPAC form fields (9.20 KB, patch)
2022-08-30 17:00 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: Display pronouns field (4.51 KB, patch)
2022-08-30 17:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: API spec update (2.07 KB, patch)
2022-08-30 17:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: (follow-up) fix typo in kohastructure.sql (1.74 KB, patch)
2022-08-30 17:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: (QA follow-up) Exec (669 bytes, patch)
2022-08-30 17:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form (1.65 KB, patch)
2022-08-30 17:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: (follow-up) Change display of pronoun fields (5.77 KB, patch)
2022-08-30 17:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 10950: Database update (4.82 KB, patch)
2022-09-30 00:27 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10950: Database update (4.82 KB, patch)
2022-09-30 00:28 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10950: Schema update (2.89 KB, patch)
2022-09-30 00:28 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10950: Add intranet/OPAC form fields (9.25 KB, patch)
2022-09-30 00:28 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10950: Display pronouns field (4.57 KB, patch)
2022-09-30 00:28 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10950: API spec update (2.13 KB, patch)
2022-09-30 00:29 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10950: (follow-up) fix typo in kohastructure.sql (1.79 KB, patch)
2022-09-30 00:29 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10950: (QA follow-up) Exec (725 bytes, patch)
2022-09-30 00:29 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form (1.71 KB, patch)
2022-09-30 00:29 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10950: (follow-up) Change display of pronoun fields (5.83 KB, patch)
2022-09-30 00:29 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-09-25 17:57:19 UTC
From a librarian: I'm wondering if there is work in progress already to add more options to the gender category, such as "neither" and "both". We don't use the gender option at all, but what would be useful to us any everyone everywhere would be a way to encode preferred gender pronouns and have those pronouns display with the name somewhere, maybe with the "other name" or after all names anywhere they appear? These are just some scattered thoughts trying to help the software help us to be more inclusive. We cannot fund a development, but I imagine many libraries in the wider community would be interested in this.

Since laws vary wildly about how one's gender is defined I can certainly see the use in having both a "legal gender" field and a "preferred gender" field.
Comment 1 Colin Campbell 2017-07-06 09:48:24 UTC
Looking at a communication from a user in large public library in the UK, their local authority is standardizing the gender element on online forms as:

What is your gender identity? Please select one option only
o Male (including Trans man)
o Female (including Trans female)
o Other gender identity – please specify:
o Prefer not to say 

That would suggest increasing the options to four and having a separate field for the other field
Comment 2 Andrew Fuerste-Henry 2021-01-24 20:43:59 UTC
I like the idea of a field for pronouns! However we set it up, it should have the ability to support a locally-defined list of options.
 
> Since laws vary wildly about how one's gender is defined I can certainly see
> the use in having both a "legal gender" field and a "preferred gender" field.

I'm hesitant to go with this construction. "Legal/preferred" has a strong possibility to carry connotations of "real/imagined" for some folks. Further, we should not overly-conflate gender and pronouns. They're very much intertwined, but not quite synonymous.
Comment 3 David Cook 2021-01-24 23:07:53 UTC
I think Andrew is right about keeping separate gender and pronouns, and having the data being localized. 

Either we should update authorized values or create a new "Local Data" system which supports locales.
Comment 4 Heather 2021-03-18 17:26:40 UTC
We don't (and don't want to) collect gender information, but would love to have an optional field for pronoun preferences!  Most useful for us would be a free text field so that the most options could be included, including multiple pronoun preferences (e.g., "it or xe, not they")  We wouldn't be using the pronoun field for any notice generation, but it would be handy for providing better in-person, phone, etc. service for patrons who want us to know and use their preferred pronouns.
Comment 5 David Cook 2021-03-18 22:27:51 UTC
Actually, in retrospect, could this be handled by a "Borrower Attributes" field?
Comment 6 Heather 2021-03-19 20:55:33 UTC
(In reply to David Cook from comment #5)
> Actually, in retrospect, could this be handled by a "Borrower Attributes"
> field?

Yes, it certainly could, but if there were a supplied Pronoun field for the patron to fill in, I think that's a step towards inclusiveness.  In my opinion, it should be an optional field, but the fact that it would be there--a Pronoun field to allow free text to be filled in, should the patron feel comfortable and wish to share their pronouns with library staff--would be a statement about inclusiveness and respect in the catalog design.
Comment 7 Katrin Fischer 2021-03-21 13:36:51 UTC
You can make the additional patron attributes editable in the OPAC, but I can see how a designated field would be nicer and send a good message too.
Comment 8 David Cook 2021-03-21 23:40:25 UTC
(In reply to Heather from comment #4)
> Most useful for us would be
> a free text field so that the most options could be included, including
> multiple pronoun preferences (e.g., "it or xe, not they") 

A free text field could make things easier for developers.

Just for context, where do you see pronoun information being used in the library? Would it only be for human-to-human interactions or would it be needed for any machine-generated interactions?
Comment 9 Heather 2021-03-22 15:46:58 UTC
For us, it is only informational for human-to-human interactions, and for providing better service.  We wouldn't be using it for any machine-generated purposes.

Input would be needed, though, from other libraries, of course.
Comment 10 Ray Delahunty 2022-06-01 07:49:50 UTC
Following a number of complaints relating to gender self-identity we have changed our data feed from the university registry system to pull the 'Preferred name' rather than the 'Given name' from that system and use that to populate the borrowers.firstname . When we move to using API available in 21.05 we will also be massively trimming back what is included in the borrowers table and will be removing title and sex (for example) as they are not relevant to the services we provide. We are being offered a 'personal pronoun' and I think we will store this in borrowers.sort1 for now, and display it to library staff.
Comment 11 Lucas Gass 2022-06-08 20:40:48 UTC
A lot of libraries would still like to see this a designated field. It would be great if we could get this to Koha for 22.11
Comment 12 Morgan Daigneault 2022-06-08 20:47:14 UTC
This would be great to have. I think it would make the most sense to include it as an optional free text field with the rest of the patron identity info. When it’s added as an additional attribute, it’s far removed from that info, which is where it would be most useful to have for patron interactions. Echoing others in that the purpose would be less for collecting data and more for informational purposes in the spirit of good service and inclusivity (for example, knowing how to address a patron when calling them on the phone).
Comment 13 Martin Renvoize 2022-06-09 09:07:32 UTC
I recently added 'Middle name' as a field.. I'm sure someone could use the work there as a template for adding a 'Pronouns' field simply enough.

Marking as Academy.
Comment 14 Lucas Gass 2022-06-09 14:18:03 UTC
Created attachment 135883 [details] [review]
Bug 10950: Database update
Comment 15 Lucas Gass 2022-06-09 14:22:10 UTC
Created attachment 135886 [details] [review]
Bug 10950: Database update
Comment 16 Lucas Gass 2022-06-09 14:26:49 UTC
Created attachment 135887 [details] [review]
Bug 10950: API spec update
Comment 17 Lucas Gass 2022-06-09 14:34:52 UTC
Created attachment 135890 [details] [review]
Bug 10950: Schema update
Comment 18 Lucas Gass 2022-06-09 16:03:45 UTC
Created attachment 135908 [details] [review]
Bug 10950: Add intranet/OPAC form fields
Comment 19 Lucas Gass 2022-06-09 16:25:52 UTC
Created attachment 135909 [details] [review]
Bug 10950: Display pronouns field
Comment 20 Martin Renvoize 2022-06-10 06:55:17 UTC
Comment on attachment 135887 [details] [review]
Bug 10950: API spec update

Review of attachment 135887 [details] [review]:
-----------------------------------------------------------------

::: api/v1/swagger/definitions/patron.yaml
@@ +37,5 @@
> +  pronouns:
> +    type:
> +      - string
> +      - "null"
> +    description: initials of the patron

Tiny error here in the description ;P
Comment 21 Lucas Gass 2022-06-10 17:55:04 UTC
Created attachment 135957 [details] [review]
Bug 10950: API spec update

Test plan:
1. Apply patch, restart_all, and updatedatabase
2. In the staff client go to a patron record or create a new patron.
3. Notice the pronouns field, make sure you add a value to it.
4. Now notice that the value should display in parentheses in places where the patron name is displayed.
5. Go to the details page and you should see the value display in quotes. ( next to othernames )

6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField.
7. Check to make sure you can make the field required with BorrowerMandatoryField

8. Go to the OPAC to self register. The pronouns field should appear in the form.
9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ).
10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ).

11. Try some notices like ISSUESLIP. You should be able to add either <<borrowers.pronouns>> or [% borrower.pronoun %] to the notice and have it display when you generate the notice.
Comment 22 Owen Leonard 2022-06-13 12:37:46 UTC
As a future improvement, we might want to do something like what I implemented for my library's internal employee directory app: A JS plugin called Tom Select (https://tom-select.js.org/) which allows you to specify some predefined choices but also allows the user to enter their own custom values instead. The predefined choices could be added as authorized values.
Comment 23 Owen Leonard 2022-06-13 12:38:57 UTC
I think this is a typo in installer/data/mysql/kohastructure.sql, line 1397:

`pronouns` longtext COLLATE utfmb4_unicode_ci DEFAULT NULL COMMENT 'patron/borrower pronouns',

Should be "utf8mb4_unicode_ci" instead?
Comment 24 Lucas Gass 2022-06-13 17:30:28 UTC
Created attachment 136037 [details] [review]
Bug 10950: (follow-up) fix typo in kohastructure.sql
Comment 25 Martin Renvoize 2022-06-14 08:39:07 UTC
Created attachment 136058 [details] [review]
Bug 10950: Database update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 26 Martin Renvoize 2022-06-14 08:39:11 UTC
Created attachment 136059 [details] [review]
Bug 10950: Schema update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 27 Martin Renvoize 2022-06-14 08:39:15 UTC
Created attachment 136060 [details] [review]
Bug 10950: Add intranet/OPAC form fields

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 28 Martin Renvoize 2022-06-14 08:39:19 UTC
Created attachment 136061 [details] [review]
Bug 10950: Display pronouns field

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 29 Martin Renvoize 2022-06-14 08:39:24 UTC
Created attachment 136062 [details] [review]
Bug 10950: API spec update

Test plan:
1. Apply patch, restart_all, and updatedatabase
2. In the staff client go to a patron record or create a new patron.
3. Notice the pronouns field, make sure you add a value to it.
4. Now notice that the value should display in parentheses in places where the patron name is displayed.
5. Go to the details page and you should see the value display in quotes. ( next to othernames )

6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField.
7. Check to make sure you can make the field required with BorrowerMandatoryField

8. Go to the OPAC to self register. The pronouns field should appear in the form.
9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ).
10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ).

11. Try some notices like ISSUESLIP. You should be able to add either <<borrowers.pronouns>> or [% borrower.pronoun %] to the notice and have it display when you generate the notice.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 30 Martin Renvoize 2022-06-14 08:39:28 UTC
Created attachment 136063 [details] [review]
Bug 10950: (follow-up) fix typo in kohastructure.sql

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 31 Martin Renvoize 2022-06-14 08:39:34 UTC
Created attachment 136064 [details] [review]
Bug 10950: (QA follow-up) Exec
Comment 32 Katrin Fischer 2022-06-14 09:10:36 UTC
(In reply to Owen Leonard from comment #22)
> As a future improvement, we might want to do something like what I
> implemented for my library's internal employee directory app: A JS plugin
> called Tom Select (https://tom-select.js.org/) which allows you to specify
> some predefined choices but also allows the user to enter their own custom
> values instead. The predefined choices could be added as authorized values.

I like this idea. Maybe as an in-between solution we could treat it like the bsort1 and bsort2 and make it optionally a pull down? That could be a separate depending bug.
Comment 33 Jonathan Druart 2022-06-16 13:43:08 UTC
To make this change usable I think we should have a new AV category to list the different choices. By default it could come with a predefined list that would be translatable.

Unless we really want to keep it a free text field?
Comment 34 Katrin Fischer 2022-06-16 16:47:53 UTC
(In reply to Jonathan Druart from comment #33)
> To make this change usable I think we should have a new AV category to list
> the different choices. By default it could come with a predefined list that
> would be translatable.
> 
> Unless we really want to keep it a free text field?

I think that was intended, what do you think about just a category, but leave empty, and make it like bsort1 (free text but AV possible?)
Comment 35 David Cook 2022-06-16 23:44:08 UTC
(In reply to Owen Leonard from comment #22)
> As a future improvement, we might want to do something like what I
> implemented for my library's internal employee directory app: A JS plugin
> called Tom Select (https://tom-select.js.org/) which allows you to specify
> some predefined choices but also allows the user to enter their own custom
> values instead. The predefined choices could be added as authorized values.

I like the sound of being able to choose between your own free text or a predefined choice
Comment 36 Katrin Fischer 2022-06-17 08:41:39 UTC
I've filed a new bug to not hold this up:
Bug 30981 - Add option to configure preferred pronouns as a pull down
Comment 37 Jonathan Druart 2022-06-17 09:18:02 UTC
(In reply to Katrin Fischer from comment #36)
> I've filed a new bug to not hold this up:
> Bug 30981 - Add option to configure preferred pronouns as a pull down

The problem I see is, if we start with free text and want a AV list by default next, the upgrade process will be harder. Not blocking, just noting.
Comment 38 Katrin Fischer 2022-06-17 10:04:21 UTC
(In reply to Jonathan Druart from comment #37)
> (In reply to Katrin Fischer from comment #36)
> > I've filed a new bug to not hold this up:
> > Bug 30981 - Add option to configure preferred pronouns as a pull down
> 
> The problem I see is, if we start with free text and want a AV list by
> default next, the upgrade process will be harder. Not blocking, just noting.

I agree, but I think as this is a new feature, we have some time prior release to figure it out.
Comment 39 Katrin Fischer 2022-08-20 09:50:07 UTC
Can you please rebase?
Comment 40 Lucas Gass 2022-08-22 15:30:50 UTC
Created attachment 139606 [details] [review]
Bug 10950: Database update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 41 Lucas Gass 2022-08-22 15:30:56 UTC
Created attachment 139607 [details] [review]
Bug 10950: Schema update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 42 Lucas Gass 2022-08-22 15:31:01 UTC
Created attachment 139608 [details] [review]
Bug 10950: Add intranet/OPAC form fields

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 43 Lucas Gass 2022-08-22 15:31:06 UTC
Created attachment 139609 [details] [review]
Bug 10950: Display pronouns field

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 44 Lucas Gass 2022-08-22 15:31:10 UTC
Created attachment 139610 [details] [review]
Bug 10950: API spec update

Test plan:
1. Apply patch, restart_all, and updatedatabase
2. In the staff client go to a patron record or create a new patron.
3. Notice the pronouns field, make sure you add a value to it.
4. Now notice that the value should display in parentheses in places where the patron name is displayed.
5. Go to the details page and you should see the value display in quotes. ( next to othernames )

6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField.
7. Check to make sure you can make the field required with BorrowerMandatoryField

8. Go to the OPAC to self register. The pronouns field should appear in the form.
9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ).
10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ).

11. Try some notices like ISSUESLIP. You should be able to add either <<borrowers.pronouns>> or [% borrower.pronoun %] to the notice and have it display when you generate the notice.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 45 Lucas Gass 2022-08-22 15:31:15 UTC
Created attachment 139611 [details] [review]
Bug 10950: (follow-up) fix typo in kohastructure.sql

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 46 Lucas Gass 2022-08-22 15:31:20 UTC
Created attachment 139612 [details] [review]
Bug 10950: (QA follow-up) Exec
Comment 47 Lucas Gass 2022-08-22 15:32:55 UTC
rebased for current master
Comment 48 Andrew Fuerste-Henry 2022-08-22 15:54:44 UTC
I was successful with everything in this test plan except generating a notice. 
Calling <<borrowers.pronoun>> worked fine.
Using [% borrower.pronoun %] gave me a big angry error:

"ERROR PROCESSING TEMPLATE: undef error - The method Koha::Patron->pronoun is not covered by tests!"
Comment 49 Lucas Gass 2022-08-22 16:54:16 UTC
(In reply to Andrew Fuerste-Henry from comment #48)
> I was successful with everything in this test plan except generating a
> notice. 
> Calling <<borrowers.pronoun>> worked fine.
> Using [% borrower.pronoun %] gave me a big angry error:
> 
> "ERROR PROCESSING TEMPLATE: undef error - The method Koha::Patron->pronoun
> is not covered by tests!"

Andrew, this is my fault. The test plan for step 11 should be:

11. Try some notices like ISSUESLIP. You should be able to add either <<borrowers.pronouns>> or [% borrower.pronouns %] to the notice and have it display when you generate the notice.

It is [% borrower.pronouns %] not [% borrower.pronoun %]
Comment 50 ByWater Sandboxes 2022-08-22 17:16:31 UTC
Created attachment 139615 [details] [review]
Bug 10950: Database update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 51 ByWater Sandboxes 2022-08-22 17:16:35 UTC
Created attachment 139616 [details] [review]
Bug 10950: Schema update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 52 ByWater Sandboxes 2022-08-22 17:16:39 UTC
Created attachment 139617 [details] [review]
Bug 10950: Add intranet/OPAC form fields

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 53 ByWater Sandboxes 2022-08-22 17:16:43 UTC
Created attachment 139618 [details] [review]
Bug 10950: Display pronouns field

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 54 ByWater Sandboxes 2022-08-22 17:16:47 UTC
Created attachment 139619 [details] [review]
Bug 10950: API spec update

Test plan:
1. Apply patch, restart_all, and updatedatabase
2. In the staff client go to a patron record or create a new patron.
3. Notice the pronouns field, make sure you add a value to it.
4. Now notice that the value should display in parentheses in places where the patron name is displayed.
5. Go to the details page and you should see the value display in quotes. ( next to othernames )

6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField.
7. Check to make sure you can make the field required with BorrowerMandatoryField

8. Go to the OPAC to self register. The pronouns field should appear in the form.
9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ).
10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ).

11. Try some notices like ISSUESLIP. You should be able to add either <<borrowers.pronouns>> or [% borrower.pronoun %] to the notice and have it display when you generate the notice.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 55 ByWater Sandboxes 2022-08-22 17:16:51 UTC
Created attachment 139620 [details] [review]
Bug 10950: (follow-up) fix typo in kohastructure.sql

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 56 ByWater Sandboxes 2022-08-22 17:16:55 UTC
Created attachment 139621 [details] [review]
Bug 10950: (QA follow-up) Exec

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 57 Andrew Fuerste-Henry 2022-08-22 17:18:45 UTC
Test plan successful once I fixed my notice!
Comment 58 Katrin Fischer 2022-08-28 11:41:17 UTC
Created attachment 139908 [details] [review]
Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form

definded => defined
Comment 59 Katrin Fischer 2022-08-28 11:47:45 UTC
Hi Lucas, 

1) Changes to patron name display in general

I am a bit hesitant about the changes to koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc.

To me the pronouns don't feel like a part of the name and therefore I'd prefer to keep them separate from the common name include.

My suggestion would be to show them separately but prominently in the brief patron information on the left side of patron account in the staff interface instead. At the moment we create a very long display string, even with 'short' name parts.

But this is certainly something we could argue about and feel free to ask others for their opinions please!

To give some examples:

Headings in the patron account:
Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559)

Staff detail:
Checked out to Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) : due 09/02/2022 

Accounting tab:
Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) has no outstanding fines.

Notices tab, h1:
Sent notices for Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559)


.. if you insist, there are 2 things in the include:

1) Do we need pronouns for organisations? :)

type = I is organisations often used for libraries or schools. I think pronouns would not be required here:

[%- IF data.category_type == 'I' -%]
-        [%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%]
+        [%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%] [% IF data.pronouns %]([% data.pronouns | html %])[% END %]


2) Missing space

We are also missing a space:
Floyd Middle (Other_name) Delgado(he/him) 

3) Details tab in staff

And unrelated: currently pronouns show up under "contact information", but that doesn't feel quite right for placement and I don't like the quotes for some reason:

Contact information
“she/her”

    6661 Library Rd.
    Springfield, MA 44224
Comment 60 Katrin Fischer 2022-08-28 11:48:40 UTC
Please note the follow-up for the typo!
Comment 61 Andrew Fuerste-Henry 2022-08-29 13:44:17 UTC
Good catch on that missing space! And I agree about the use of quotes around pronouns in Contact Information -- it feels sort of off and non-standard. Using parentheses would make more sense to me. But I like it in the Contact Information section generally; that's where I'd expect to find information about how to address someone.

(As an aside, I see we're similarly putting Other Name in parentheses some places and quotes others. I feel like for American English usage that should be quotes all over, but that at least another bug and probably a larger linguistic conversation.)

I don't know the full extent of the change Katrin suggests to not include pronouns in koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc. I like the general idea, though, of only including pronouns in a few places in the patron record, not necessarily pushing them out to everywhere the patron name appears.
Comment 62 Lucas Gass 2022-08-29 22:26:27 UTC
Created attachment 139968 [details] [review]
Bug 10950: (follow-up) Change display of pronoun fields
Comment 63 Lucas Gass 2022-08-29 22:30:13 UTC
Thanks for the feedback Cait and Andrew! I agree that adding the pronouns to the patron-title include makes things cumbersome. 

Since this is mostly informational for staff I think it is adequate to show it in the brief display and on the details page. The most sense to be would be underneath that patrons name, so that is where I added it in my follow-up. 

Also, happy to have other opinions therefore I am resetting this to Needs Signoff.
Comment 64 ByWater Sandboxes 2022-08-30 17:00:48 UTC
Created attachment 139983 [details] [review]
Bug 10950: Database update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 65 ByWater Sandboxes 2022-08-30 17:00:53 UTC
Created attachment 139984 [details] [review]
Bug 10950: Schema update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 66 ByWater Sandboxes 2022-08-30 17:00:57 UTC
Created attachment 139985 [details] [review]
Bug 10950: Add intranet/OPAC form fields

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 67 ByWater Sandboxes 2022-08-30 17:01:01 UTC
Created attachment 139986 [details] [review]
Bug 10950: Display pronouns field

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 68 ByWater Sandboxes 2022-08-30 17:01:06 UTC
Created attachment 139987 [details] [review]
Bug 10950: API spec update

Test plan:
1. Apply patch, restart_all, and updatedatabase
2. In the staff client go to a patron record or create a new patron.
3. Notice the pronouns field, make sure you add a value to it.
4. Now notice that the value should display in parentheses in places where the patron name is displayed.
5. Go to the details page and you should see the value display in quotes. ( next to othernames )

6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField.
7. Check to make sure you can make the field required with BorrowerMandatoryField

8. Go to the OPAC to self register. The pronouns field should appear in the form.
9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ).
10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ).

11. Try some notices like ISSUESLIP. You should be able to add either <<borrowers.pronouns>> or [% borrower.pronoun %] to the notice and have it display when you generate the notice.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 69 ByWater Sandboxes 2022-08-30 17:01:11 UTC
Created attachment 139988 [details] [review]
Bug 10950: (follow-up) fix typo in kohastructure.sql

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 70 ByWater Sandboxes 2022-08-30 17:01:16 UTC
Created attachment 139989 [details] [review]
Bug 10950: (QA follow-up) Exec

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 71 ByWater Sandboxes 2022-08-30 17:01:21 UTC
Created attachment 139990 [details] [review]
Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form

definded => defined

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 72 ByWater Sandboxes 2022-08-30 17:01:26 UTC
Created attachment 139991 [details] [review]
Bug 10950: (follow-up) Change display of pronoun fields

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 73 Chris Cormack 2022-09-30 00:27:17 UTC
Created attachment 141094 [details] [review]
Bug 10950: Database update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 74 Chris Cormack 2022-09-30 00:28:41 UTC
Created attachment 141095 [details] [review]
Bug 10950: Database update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 75 Chris Cormack 2022-09-30 00:28:46 UTC
Created attachment 141096 [details] [review]
Bug 10950: Schema update

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 76 Chris Cormack 2022-09-30 00:28:52 UTC
Created attachment 141097 [details] [review]
Bug 10950: Add intranet/OPAC form fields

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 77 Chris Cormack 2022-09-30 00:28:57 UTC
Created attachment 141098 [details] [review]
Bug 10950: Display pronouns field

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 78 Chris Cormack 2022-09-30 00:29:03 UTC
Created attachment 141099 [details] [review]
Bug 10950: API spec update

Test plan:
1. Apply patch, restart_all, and updatedatabase
2. In the staff client go to a patron record or create a new patron.
3. Notice the pronouns field, make sure you add a value to it.
4. Now notice that the value should display in parentheses in places where the patron name is displayed.
5. Go to the details page and you should see the value display in quotes. ( next to othernames )

6. Check to make sure you can hide the pronouns field via BorrowerUnwantedField.
7. Check to make sure you can make the field required with BorrowerMandatoryField

8. Go to the OPAC to self register. The pronouns field should appear in the form.
9. Make sure you can make it required ( PatronSelfRegistrationBorrowerMandatoryField ) and that you can hide it ( PatronSelfRegistrationBorrowerUnwantedField ).
10. Once registered check 'your personal details'. Check that the field can be required (PatronSelfModificationMandatoryField) or hidden ( PatronSelfModificationBorrowerUnwantedField ).

11. Try some notices like ISSUESLIP. You should be able to add either <<borrowers.pronouns>> or [% borrower.pronoun %] to the notice and have it display when you generate the notice.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 79 Chris Cormack 2022-09-30 00:29:09 UTC
Created attachment 141100 [details] [review]
Bug 10950: (follow-up) fix typo in kohastructure.sql

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 80 Chris Cormack 2022-09-30 00:29:15 UTC
Created attachment 141101 [details] [review]
Bug 10950: (QA follow-up) Exec

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 81 Chris Cormack 2022-09-30 00:29:22 UTC
Created attachment 141102 [details] [review]
Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form

definded => defined

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 82 Chris Cormack 2022-09-30 00:29:27 UTC
Created attachment 141103 [details] [review]
Bug 10950: (follow-up) Change display of pronoun fields

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 83 Tomás Cohen Arazi 2022-10-03 18:14:49 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!