Because of a change in the itemtypes table structure some of the sample files can no longer be loaded correctly. Patch applies change from 10965 to the translated itemtype sample files. To test: - Install the specific language and run the web installer. Or: - Truncate or delete all from the itemtypes table in your database. - Try to run the complete SQL in the itemtypes sample files. - Verify the table is filled correctly.
Created attachment 21600 [details] [review] Bug 10969: Fix sample itemtypes for translated installers To test: - Install the specific language and run the web installer. Or: - Truncate or delete all from the itemtypes table in your database. - Try to run the complete SQL in the itemtypes sample files. Verify the table is filled correctly.
Created attachment 21606 [details] [review] [SIGNED-OFF] Bug 10969: Fix sample itemtypes for translated installers To test: - Install the specific language and run the web installer. Or: - Truncate or delete all from the itemtypes table in your database. - Try to run the complete SQL in the itemtypes sample files. Verify the table is filled correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works for all languages. No koha-qa errors. Tested removing itemtypes, then loading new file, and checking on staff. For de, es, nb, and pl no problems. For ru I disable foreign keys constraint before TRUNCATE and reenable it afterwards.
Marking as release blocker.
And what about french db? is it needed too? Mathieu
I checked all languages and French was using a differnt SQL statement.
thank you
PAtch fixing some weird MySQL, nothing specific to say about it, no possible side-effect for existing setup. passed QA
Created attachment 22090 [details] [review] Bug 10969: Fix sample itemtypes for translated installers To test: - Install the specific language and run the web installer. Or: - Truncate or delete all from the itemtypes table in your database. - Try to run the complete SQL in the itemtypes sample files. Verify the table is filled correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works for all languages. No koha-qa errors. Tested removing itemtypes, then loading new file, and checking on staff. For de, es, nb, and pl no problems. For ru I disable foreign keys constraint before TRUNCATE and reenable it afterwards. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Pushed to master. Thanks, Katrin!