Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update
Summary: Update MARC21 frameworks to Update Nr. 17 - DB update
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-29 17:11 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:23 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update (2.92 KB, patch)
2013-09-29 17:22 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update (2.97 KB, patch)
2013-10-20 23:27 UTC, David Cook
Details | Diff | Splinter Review
Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update (3.08 KB, patch)
2013-12-06 08:50 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2013-09-29 17:11:34 UTC
Update MARC21 frameworks to Update Nro. 17 for current installs
Comment 1 Bernardo Gonzalez Kriegel 2013-09-29 17:22:40 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-10-01 18:39:36 UTC
Patch applied cleanly, go forth and signoff
Comment 3 David Cook 2013-10-20 23:27:22 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2013-12-06 08:50:48 UTC
Created attachment 23332 [details] [review]
Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update

Database counterpart of Bug 10962. Updates existing MARC21
default frameworks to Update Nr. 17 (September 2013)

To test
1) Apply patch
2) run updatedatabase.pl
3) Verify new subtags

biblio
    015_q 020_q 024_q 027_q 800_7 810_7 811_7 830_7

authorities
    020_q 024_q

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2013-12-06 08:58:00 UTC
Code looks good to me. No complaints from qa tools.
Tested the dbrev. Verified the changes with LOC site.
Passed QA

Just wondering about two points:
How should we get the changes propagated to other frameworks? (Probably most users would like to update them, but indeed some might not.)
The Control subfield $7 on 8XX looks like we need a clone of the Leader plugin?
Comment 6 Galen Charlton 2013-12-06 15:36:53 UTC
(In reply to M. de Rooy from comment #5)
> How should we get the changes propagated to other frameworks? (Probably most
> users would like to update them, but indeed some might not.)

The work Bernardo started in bug 10963 suggests a way that this might become easier in the future -- once a format-specific stock framework is recast as being a subset of the default framework (+ difference in subfield visibility), it would be easier to let users say, for example, please refresh my SER framework based on the current state of the default framework.

> The Control subfield $7 on 8XX looks like we need a clone of the Leader
> plugin?

That's a good idea, though it would be a smaller version since 8XX$7 has only two positions defined.
Comment 7 Galen Charlton 2013-12-06 15:56:02 UTC
Pushed to master.  Thanks, Bernardo!
Comment 8 Galen Charlton 2013-12-06 15:56:24 UTC
I also pushed to a follow-up to ensure that the update is run only for MARC21 installations.
Comment 9 Fridolin Somers 2013-12-24 09:36:31 UTC
Patch pushed to 3.14.x, will be in 3.14.2.
(Creates update 3.14.01.001)
Comment 10 Chris Nighswonger 2014-02-07 16:11:40 UTC
FWIW, upgrading koha-common from 3.14.01 to 3.14.03 threw the following:

Upgrade to 3.14.01.001 done (Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update)
DBD::mysql::db do failed: Table 'koha_biblios.collections_tracking' doesn't exist at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 7830.

It is probably a good idea to trap such errors if they are expected by testing for the existence of the table perior to operating on it.
Comment 11 Bernardo Gonzalez Kriegel 2014-02-07 16:37:59 UTC
(In reply to Chris Nighswonger from comment #10)
> FWIW, upgrading koha-common from 3.14.01 to 3.14.03 threw the following:
> 
> Upgrade to 3.14.01.001 done (Bug 10970 - Update MARC21 frameworks to Update
> Nr. 17 - DB update)
> DBD::mysql::db do failed: Table 'koha_biblios.collections_tracking' doesn't
> exist at
> /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
> 7830.

That message belongs to the next db update, for Bug 11384