In Cataloging, a ? documentation page on IFLA web site. The current implementation rely on the tag tab to select the appropriate IFLA documentation web page. It doesn't work when UNIMARC tag are displayed in a tab which digit is different for tag first digit. To reproduce the bug: - Modify default framework, put all 200 subfields in tab 1 - Add a new biblio record - Click on ? on 200 field => Wrong IFLA page is opened Apply the patch and retry...
Created attachment 21710 [details] [review] Proposed patch
Patch applied cleanly, go forth and signoff
It's sad only the 1996 version is online in html. But do you think it would be possible for french ppl version to have link to the french version of the manual on BNF website? http://www.bnf.fr/fr/professionnels/anx_formats/a.unimarc_manuel_format_bibliographique.html Or maybe to the version of ABES network (used by french academic libraries, but some details are only on BNF website...) http://documentation.abes.fr/sudoc/formats/unmb/index.htm Mathieu
> It's sad only the 1996 version is online in html. Imagine a community of librarians managing collaboratively an up-to-date UNIMARC documentation, for free, for freedom... Hey, isn't IFLA supposed to do that? > But do you think it would be possible for french ppl version to have link to > the french version of the manual on BNF website? > http://www.bnf.fr/fr/professionnels/anx_formats/a. > unimarc_manuel_format_bibliographique.html +1 But I can't find direct link to UNIMARC specific tag documentation. > Or maybe to the version of ABES network (used by french academic libraries, > but some details are only on BNF website...) > http://documentation.abes.fr/sudoc/formats/unmb/index.htm Direct links are available. It could work. IFLA documentation was selected by default, and since it is obsoleting, we could switch to ABES documentation without damage. Dont' you think ABES will require specific authorisation to link to their web site. Would you mind asking them? But such an enhencement must be the object of another bug report. In the meantime, my patch is a just a quick fix to an annoying bug, which can easily be signed-off...
(In reply to Frédéric Demians from comment #4) > > It's sad only the 1996 version is online in html. > > Imagine a community of librarians managing collaboratively an up-to-date > UNIMARC documentation, for free, for freedom... Hey, isn't IFLA supposed to > do that? I will volunteer for the next meeting in Lyon. The only way to attend the meeting without paying a BIG contribution... > > > But do you think it would be possible for french ppl version to have link to > > the french version of the manual on BNF website? > > http://www.bnf.fr/fr/professionnels/anx_formats/a. > > unimarc_manuel_format_bibliographique.html > > +1 > > But I can't find direct link to UNIMARC specific tag documentation. Table of contents on the page I gave Maybe the links are not made the same way But it seems to be http://multimedia.bnf.fr/unimarcb_trad/B022-6-2010.pdf http://multimedia.bnf.fr/unimarcb_trad/B127-6-2010.pdf http://multimedia.bnf.fr/unimarcb_trad/B304-6-2010.pdf But for some tags there is no links, only information about the "bloc" ex : 440 Devient 441 Devient partiellement 442 Remplacé par 443 Remplacé partiellement par 444 Absorbé par Only info about the block : http://www.bnf.fr/documents/B4XX-6-2010.pdf Sadly, for authorities, there is only a big pdf in french http://www.bnf.fr/documents/UnimarcA.pdf > > > Or maybe to the version of ABES network (used by french academic libraries, > > but some details are only on BNF website...) > > http://documentation.abes.fr/sudoc/formats/unmb/index.htm > > Direct links are available. It could work. IFLA documentation was selected > by default, and since it is obsoleting, we could switch to ABES > documentation without damage. Dont' you think ABES will require specific > authorisation to link to their web site. Would you mind asking them? But the Methodological Guide has been "opened" 2/3 years ago. Before it was accessible only with authentification. They put it on licence CC (BY NC SA), so I suppose they won't object if links are made to it. http://documentation.abes.fr/sudoc/formats/unmb/index.htm But we could ask to be sure. > > But such an enhencement must be the object of another bug report. In the > meantime, my patch is a just a quick fix to an annoying bug, which can > easily be signed-off... Mathieu
Created attachment 21779 [details] [review] [SIGNED-OFF] Bug 10982 Link to IFLA UNIMARC documentation in Cataloging In Cataloging, a ? documentation page on IFLA web site. The current implementation rely on the tag tab to select the appropriate IFLA documentation web page. It doesn't work when UNIMARC tag are displayed in a tab which digit is different for tag first digit. To reproduce the bug: - Modify default framework, put all 200 subfields in tab 1 - Add a new biblio record - Click on ? on 200 field => Wrong IFLA page is opened Apply the patch and retry... Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Simple fix. Work as described. No koha-qa errors Test on UNIMARC install 1) Switched all 2xx tags to tab 1 2) press any 2xx ?, wrong page 3) patch applied 4) links are now correct
Looks more like a bug fix to me than an enh - marking accordingly. Changing the tab a field is displayed in is a standard feature, so documentation links should not break if you do it.
Bernardo: Thanks for testing and signing-off. Katrin: you're correct of course, concerning the bug wording. Mathieu: would you mind opening a new bug-enhancement with your findings about ABES/BNF links rather than IFLA, or a proposal to HTMLize IFLA doc. It would keep track of this discussion. Thanks.
Ok Frederic Mathieu
QA comment : * passes koha-qa.pl * no side effect (I've checked that MARC21 links are still working) * fixes a bug passed QA
Created attachment 22144 [details] [review] Bug 10982 Link to IFLA UNIMARC documentation in Cataloging In Cataloging, a ? documentation page on IFLA web site. The current implementation rely on the tag tab to select the appropriate IFLA documentation web page. It doesn't work when UNIMARC tag are displayed in a tab which digit is different for tag first digit. To reproduce the bug: - Modify default framework, put all 200 subfields in tab 1 - Add a new biblio record - Click on ? on 200 field => Wrong IFLA page is opened Apply the patch and retry... Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Simple fix. Work as described. No koha-qa errors Test on UNIMARC install 1) Switched all 2xx tags to tab 1 2) press any 2xx ?, wrong page 3) patch applied 4) links are now correct Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Pushed to master. Thanks, Frédéric!
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Frédéric!