Bug 10983 - Unused subroutines in C4:Budgets
Summary: Unused subroutines in C4:Budgets
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Colin Campbell
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-02 09:01 UTC by Colin Campbell
Modified: 2015-06-04 23:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.62 KB, patch)
2013-10-02 09:06 UTC, Colin Campbell
Details | Diff | Splinter Review
Bug 10983: Remove unused private subroutines from C4::Budgets (2.19 KB, patch)
2013-12-11 18:21 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 10983: Remove unused private subroutines from C4::Budgets (2.27 KB, patch)
2013-12-13 10:56 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2013-10-02 09:01:26 UTC
C4::Budgets contains two private subroutines _columns and _filter_fields. _filter_fields is not called anywhere else and _columns is only used by _filter_fields. They should be removed
Comment 1 Colin Campbell 2013-10-02 09:06:02 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-10-02 09:35:50 UTC
Patch applied cleanly, go forth and signoff
Comment 3 I'm just a bot 2013-10-28 06:15:47 UTC
Patch applied cleanly, go forth and signoff
Comment 4 Galen Charlton 2013-12-11 18:21:25 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-12-13 10:56:53 UTC
Created attachment 23509 [details] [review]
Bug 10983: Remove unused private subroutines from C4::Budgets

The subroutine _filter_fields is not used by the module
and the sub _columns is only used by it

This patch removes the dead code.

To test:

[1] Verify that the following tests pass

    t/Budgets.t
    t/Budgets/CanUserModifyBudget.t
    t/Budgets/CanUserUseBudget.t
    t/db_dependent/Acquisition.t
    t/db_dependent/Acquisition/GetOrdersByBiblionumber.t
    t/db_dependent/Acquisition/Invoices.t
    t/db_dependent/Acquisition/OrderFromSubscription.t
    t/db_dependent/Acquisition/TransferOrder.t
    t/db_dependent/Acquisition/close_reopen_basket.t
    t/db_dependent/Bookseller.t
    t/db_dependent/Budgets.t
    t/db_dependent/Serials.t
    t/db_dependent/Serials_2.t

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Looks good to me.
Comment 6 Galen Charlton 2013-12-13 15:14:43 UTC
Pushed to master.  Thanks, Colin!
Comment 7 Fridolin Somers 2013-12-24 11:54:49 UTC
Patch pushed to 3.14.x, will be in 3.14.2.