Bug 10991 - C4::ImportExportFramework has unnecessary temporary file and directory management code
Summary: C4::ImportExportFramework has unnecessary temporary file and directory manage...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: IM-NEKEL404
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-03 22:59 UTC by Galen Charlton
Modified: 2023-07-08 21:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2013-10-03 22:59:48 UTC
There is code in C4::ImportExportFramework that supplies alternative code if the module File::Temp is not installed.  As File::Temp is both a core Perl module and marked as a required dependency of Koha, that code only serves to add unnecessary complexity to the module and (not that this is a core concern) reduces portability to non-Unix-like platforms.

In particular, the _createTmpDir routine is unnecessary.  Removing it would also remove a dependency on Digest::MD5.

Similarly, there's code that handles the case where File::Path is not present, but this is also a core Perl module.