Bug 11002 - Mandatory fields are not translatable
Summary: Mandatory fields are not translatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-07 08:41 UTC by Jonathan Druart
Modified: 2015-06-04 23:23 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11002: Mandatory fields are not translatable (3.83 KB, patch)
2013-10-07 08:44 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Mandatory fields are not translatable (3.88 KB, patch)
2013-10-08 13:36 UTC, Paola Rossi 		Details | Diff | Splinter Review
[PASSED-QA] Bug 11002: Mandatory fields are not translatable (3.94 KB, patch)
2013-10-21 21:05 UTC, Brendan Gallagher 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-10-07 08:41:03 UTC 
When the pref BorrowerMandatoryField is set and a librarian forget to fill fields, a js popup appears with the following message:
  "The following fields are mandatory: surname, etc."
The fields are not translatable.
Comment 1 Jonathan Druart 2013-10-07 08:44:41 UTC Comment hidden (obsolete)
Comment 2 Paola Rossi 2013-10-08 13:36:04 UTC Comment hidden (obsolete)
Comment 3 Paola Rossi 2013-10-08 13:36:44 UTC 
The patch is signed off
Comment 4 Brendan Gallagher 2013-10-21 21:05:57 UTC 
Created attachment 22182 [details] [review]
[PASSED-QA] Bug 11002: Mandatory fields are not translatable

When the pref BorrowerMandatoryField is set and a librarian forget to
fill fields, a js popup appears with the following message:
  "The following fields are mandatory: surname, etc."
The fields are not translatable.

Test plan:
- fill the pref BorrowerMandatoryField with something like:
  title|zipcode|surname|cardnumber|branchcode
- go the members/memberentry.pl?op=add page
- verify you are not allowed to add the patron without filling all
  mandatory fields.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 5 Galen Charlton 2013-10-22 05:20:12 UTC 
Pushed to master, along with a follow-up that ensures that the jQuery validator plugin is used for both new, HTML5-compatible browsers and old, non-HTML5-compatible ones.

Thanks, Jonathan!
Comment 6 Tomás Cohen Arazi (tcohen) 2013-12-05 15:27:48 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Jonathan!
Comment 7 Sophie MEYNIEUX 2013-12-17 11:52:23 UTC 
Will it be in 3.10.x ? Thanks
Comment 8 Jonathan Druart 2013-12-17 12:58:36 UTC 
I added Bernardo to the cc list.