Bug 11018 - Add order from a reverted file
Summary: Add order from a reverted file
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-08 15:06 UTC by Jonathan Druart
Modified: 2015-06-04 23:23 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11018 - Add order from a reverted file (2.30 KB, patch)
2013-10-08 15:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11018 - Add order from a reverted file (2.34 KB, patch)
2014-01-10 17:18 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 11018 - Add order from a reverted file (2.43 KB, patch)
2014-01-10 20:25 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-10-08 15:06:41 UTC
If a batch is reverted, it is not possible to create an order from this file.
Comment 1 Jonathan Druart 2013-10-08 15:25:53 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-10-30 06:59:56 UTC
Patch applied cleanly, go forth and signoff
Comment 3 Biblibre Sandboxes 2014-01-10 17:18:09 UTC
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Comment 4 Biblibre Sandboxes 2014-01-10 17:18:28 UTC Comment hidden (obsolete)
Comment 5 Pierre Angot 2014-01-10 17:29:20 UTC
Can't verify  mysql/MariaDB cli on sandbox
Comment 6 Kyle M Hall 2014-01-10 20:25:18 UTC
Created attachment 24180 [details] [review]
Bug 11018 - Add order from a reverted file

Weird behavior:
When an import is undone into catalog, the status is set to "reverted".
But if you open the add orders from iso2709, the status is automatically
set to "imported" and does not appear in the list.
So it is not possible to import a reverted batch.

Test plan:
- verify you reproduce the weird behavior
- apply this patch
- import a file and the batch into the catalog
- verify (in the your mysql/MariaDB cli) the status is "imported"
- verify it does not appears in the add orders from iso2809 page
- undo the import
- verify (in the your mysql/MariaDB cli) the status is "reverted"
- verify it appears in the add orders from iso2809 page and the status
  is always "reverted"
- finish the order

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, works as advertised.
Comment 7 Kyle M Hall 2014-01-13 12:06:48 UTC
Passed QA, but I think it prudent to ask the question "Is there any reason we shouldn't allow orders from reverted batches?" I can't imagine a reason not to, but I'm not very imaginative ; )
Comment 8 Katrin Fischer 2014-01-13 20:41:24 UTC
I think it makes sense to me not to allow it. Hm, can't really explain it beyond that reverted to indicate "unwanted" to me.
Comment 9 Galen Charlton 2014-01-17 05:26:14 UTC
(In reply to Katrin Fischer from comment #8)
> I think it makes sense to me not to allow it. Hm, can't really explain it
> beyond that reverted to indicate "unwanted" to me.

I can see why it sounds odd, but on the other hand, a reverted batch is still a staged batch -- it just /used/ to be imported.
Comment 10 Galen Charlton 2014-01-17 05:34:51 UTC
Pushed to master.  Thanks, Jonathan!
Comment 11 Fridolin Somers 2014-03-25 08:43:49 UTC
Patch pushed to 3.14.x, will be in 3.14.5