If a batch is reverted, it is not possible to create an order from this file.
Created attachment 21883 [details] [review] Bug 11018 - Add order from a reverted file Weird behavior: When an import is undone into catalog, the status is set to "reverted". But if you open the add orders from iso2709, the status is automatically set to "imported" and does not appear in the list. So it is not possible to import a reverted batch. Test plan: - verify you reproduce the weird behavior - apply this patch - import a file and the batch into the catalog - verify (in the your mysql/MariaDB cli) the status is "imported" - verify it does not appears in the add orders from iso2809 page - undo the import - verify (in the your mysql/MariaDB cli) the status is "reverted" - verify it appears in the add orders from iso2809 page and the status is always "reverted" - finish the order
Patch applied cleanly, go forth and signoff
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Created attachment 24166 [details] [review] Bug 11018 - Add order from a reverted file Weird behavior: When an import is undone into catalog, the status is set to "reverted". But if you open the add orders from iso2709, the status is automatically set to "imported" and does not appear in the list. So it is not possible to import a reverted batch. Test plan: - verify you reproduce the weird behavior - apply this patch - import a file and the batch into the catalog - verify (in the your mysql/MariaDB cli) the status is "imported" - verify it does not appears in the add orders from iso2809 page - undo the import - verify (in the your mysql/MariaDB cli) the status is "reverted" - verify it appears in the add orders from iso2809 page and the status is always "reverted" - finish the order Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Can't verify mysql/MariaDB cli on sandbox
Created attachment 24180 [details] [review] Bug 11018 - Add order from a reverted file Weird behavior: When an import is undone into catalog, the status is set to "reverted". But if you open the add orders from iso2709, the status is automatically set to "imported" and does not appear in the list. So it is not possible to import a reverted batch. Test plan: - verify you reproduce the weird behavior - apply this patch - import a file and the batch into the catalog - verify (in the your mysql/MariaDB cli) the status is "imported" - verify it does not appears in the add orders from iso2809 page - undo the import - verify (in the your mysql/MariaDB cli) the status is "reverted" - verify it appears in the add orders from iso2809 page and the status is always "reverted" - finish the order Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised.
Passed QA, but I think it prudent to ask the question "Is there any reason we shouldn't allow orders from reverted batches?" I can't imagine a reason not to, but I'm not very imaginative ; )
I think it makes sense to me not to allow it. Hm, can't really explain it beyond that reverted to indicate "unwanted" to me.
(In reply to Katrin Fischer from comment #8) > I think it makes sense to me not to allow it. Hm, can't really explain it > beyond that reverted to indicate "unwanted" to me. I can see why it sounds odd, but on the other hand, a reverted batch is still a staged batch -- it just /used/ to be imported.
Pushed to master. Thanks, Jonathan!
Patch pushed to 3.14.x, will be in 3.14.5