Adding new category in authorized values. If not fill any field it save blank record
Created attachment 21890 [details] [review] Adding new category in authorized values If not fill any field it save blank record To Test: 1) Go to Authorized values. 2) Create New Category. 3) If you not fill the Category field it will not save the record.
Created attachment 21899 [details] [review] Adding new category in authorized values I sign off the patch
Why not use the validation method offered by the plugin introduced in Bug 6209? Is there a server-side check that can be added to the JavaScript-based one?
Sorry, I didn't know the discussion in bug 6209 about form validation. I think to pass status of this bug to "failed QA" because Amit wrote specific javascript code, and he didn't use the plugin instead. What do you think about it?
Created attachment 22096 [details] [review] Bug 11019 Prevent adding new empty category in authorized values Test plan: * Go to Koha > admin > authorised values > New category > save without entering a category value * You'll get a message saying "this field is required" * signoff
Created attachment 22097 [details] [review] Bug 11019 follow-up : reindenting While working on bug 11019, I saw many tabs & silly indenting. This patch fixes both
need signoff again, as I've rewritten the patch. Lowering severity, if the librarian takes care and enters a category, as he's supposed to do, no problem.
Created attachment 22110 [details] [review] Bug 11019 follow-up : reindenting While working on bug 11019, I saw many tabs & silly indenting. This patch fixes both Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Paul, Please reconsider the reindentation for the template file. I have a big patch for this page (see bug 10363).
Considering Jonathan's patch is a large improvement, I set this one "in discussion", until the bug 10363 has been pushed
Created attachment 54577 [details] [review] Bug 11019 - Require some fields when adding authorized value category This patch modifies the form for adding an authorized value so that category, authorized value, and description are required fields. Previously a new authorized value category could be saved with no data. To test, apply the patch and go to Administration -> Authorized values. - Click the "New category" button. - Click the save button without filling in category, authorized value, or description. You should be prevented from submitting the form. - Verify that filling in the required fields allows the form to be submitted. - Perform the same test when editing an existing authorized value.
Created attachment 54723 [details] [review] [SIGNED-OFF] Bug 11019 - Require some fields when adding authorized value category This patch modifies the form for adding an authorized value so that category, authorized value, and description are required fields. Previously a new authorized value category could be saved with no data. To test, apply the patch and go to Administration -> Authorized values. - Click the "New category" button. - Click the save button without filling in category, authorized value, or description. You should be prevented from submitting the form. - Verify that filling in the required fields allows the form to be submitted. - Perform the same test when editing an existing authorized value. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Created attachment 54761 [details] [review] Bug 11019 - Require some fields when adding authorized value category This patch modifies the form for adding an authorized value so that category, authorized value, and description are required fields. Previously a new authorized value category could be saved with no data. To test, apply the patch and go to Administration -> Authorized values. - Click the "New category" button. - Click the save button without filling in category, authorized value, or description. You should be prevented from submitting the form. - Verify that filling in the required fields allows the form to be submitted. - Perform the same test when editing an existing authorized value. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Hm, I just took a look at this and I have a problem: Sometimes we like to add an empty authorised value to appear as an empty/unset entry in a a pull down list. An example: Extended patron attribute linked to an authorised value list. The empty entry is the first in the list and will show if the field is empty/was not imported. Could we remove the required form the actual authorised value?
Created attachment 54924 [details] [review] Bug 11019 - Require some fields when adding authorized value category This patch modifies the form for adding an authorized value so that category, authorized value, and description are required fields. Previously a new authorized value category could be saved with no data. To test, apply the patch and go to Administration -> Authorized values. - Click the "New category" button. - Click the save button without filling in category, authorized value, or description. You should be prevented from submitting the form. - Verify that filling in the required fields allows the form to be submitted. - Perform the same test when editing an existing authorized value. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Follow-up for QA: Allow a blank authorised value to be created.
Created attachment 54948 [details] [review] [PASSED QA] Bug 11019 - Require some fields when adding authorized value category This patch modifies the form for adding an authorized value so that the category is a required fields. Previously a new authorized value category could be saved with no data. To test, apply the patch and go to Administration -> Authorized values. - Click the "New category" button. - Click the save button without filling in the category. You should be prevented from submitting the form. - Verify that filling in the required field allows the form to be submitted. - Perform the same test when editing an existing authorized value. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Follow-up for QA: Allow a blank authorised value to be created. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Amended test plan. Current patch-complexity: Small patch
Pushed to master for 16.11, thanks Owen!
Pushed in 16.05. Will be in 16.05.04.
Pushed to 3.22.x, will be in 3.22.11