Bug 11033 - In basketgroup pages, Save button and Cancel link are hidden by chooselanguage bar
Summary: In basketgroup pages, Save button and Cancel link are hidden by chooselanguag...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Mathieu Saby
QA Contact: Paul Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-10 11:43 UTC by Mathieu Saby
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
[PATCH] Bug 11033 Make Save button and Cancel link always visible on basketgroup page (1.36 KB, patch)
2013-10-10 11:49 UTC, Mathieu Saby 		Details | Diff | Splinter Review
Bug 11033 Make Save button and Cancel link always visible on basketgroup page (1.39 KB, patch)
2013-10-11 11:02 UTC, Biblibre Sandboxes 		Details | Diff | Splinter Review
Bug 11033 Make Save button and Cancel link always visible on basketgroup page (1.43 KB, patch)
2013-10-21 21:18 UTC, Paul Poulain 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-10-10 11:43:01 UTC 
In basketgroup pages, Save button and Cancel link are hidden by chooselanguage bar
This is caused by the css declaration setting body margin and padding in basketgroup.tt to 0.

M. Saby
Comment 1 Mathieu Saby 2013-10-10 11:49:54 UTC Comment hidden (obsolete)
Comment 2 Mathieu Saby 2013-10-10 12:33:31 UTC 
By the way, the code of this template file is pretty ugly, but that's not the problem here ;-)

M. Saby
Comment 3 Biblibre Sandboxes 2013-10-11 11:02:13 UTC 
Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com>
Comment 4 Biblibre Sandboxes 2013-10-11 11:02:30 UTC Comment hidden (obsolete)
Comment 5 Paul Poulain 2013-10-21 21:18:13 UTC 
QA comment: 
 * code removal only
 * passes koha-qa.pl (of course, considering it's removing code only)
 * regression test = everything fine if there's no language bar with the patch (as it was without)

passed QA
Comment 6 Paul Poulain 2013-10-21 21:18:38 UTC 
Created attachment 22191 [details] [review]
Bug 11033 Make Save button and Cancel link always visible on basketgroup page

This patch suppress the first CSS declaration in basketgroup.tt. It was unneeded, and was the cause of the Save button and Cancel link not being visible if the bar for changing language was activated.

To test :
1. activate the "language" syspref, with at least 2 languages
2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at the bottom of basketgroup page
3. Check you can use the basketgroup as before : put a basket in it, cancel, save etc.

Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 7 Mathieu Saby 2013-10-21 21:34:44 UTC 
(In reply to Paul Poulain from comment #5)
> QA comment: 
>  * code removal only
>  * passes koha-qa.pl (of course, considering it's removing code only)
>  * regression test = everything fine if there's no language bar with the
> patch (as it was without)
> 
> passed QA

I did think of regression test ;-)

Mathieu
Comment 8 Galen Charlton 2013-11-01 00:33:20 UTC 
Pushed to master.  Thanks, Mathieu!