Bug 11034 - BiblioAutoLink has incorrect return in addbiblio.pl
Summary: BiblioAutoLink has incorrect return in addbiblio.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Colin Campbell
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-10 13:06 UTC by Colin Campbell
Modified: 2015-06-04 23:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (1.19 KB, patch)
2013-10-10 13:17 UTC, Colin Campbell
Details | Diff | Splinter Review
Bug 11034: remove incorrect return for BiblioAutoLink (1.46 KB, patch)
2013-10-20 18:02 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 11034: remove incorrect return for BiblioAutoLink (1.47 KB, patch)
2013-10-20 18:04 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 11034: remove incorrect return for BiblioAutoLink (1.54 KB, patch)
2013-10-23 13:15 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2013-10-10 13:06:56 UTC
addbiblio.pl calls BiblioAutoLink expecting an array to be returned but the routine returns a scalar
Comment 1 Colin Campbell 2013-10-10 13:17:15 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-10-20 18:02:46 UTC Comment hidden (obsolete)
Comment 3 Galen Charlton 2013-10-20 18:04:43 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-10-23 13:15:42 UTC
Created attachment 22313 [details] [review]
Bug 11034: remove incorrect return for BiblioAutoLink

BiblioAutoLink was being called expecting an array to
be returned. The subroutine in fact returns a scalar

As the variables that the return was stored in, went
out of scope immediately. It is probably better to be
explicit that we are throwing the return away by not
going through the motions of storing it in a variable

To test:

[1] Add or save a bib record using the cataloging editor.
[2] Verify that no regressions have occurred
[3] (optional) If BiblioAddsAuthorities is on, verify that
    relevant authority records are linked to from the bib.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Galen Charlton 2013-10-23 14:16:23 UTC
Pushed to master.
Comment 6 Galen Charlton 2013-10-23 14:17:25 UTC
Thanks, Colin!
Comment 7 Tomás Cohen Arazi 2013-12-05 15:18:04 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Colin!