addbiblio.pl calls BiblioAutoLink expecting an array to be returned but the routine returns a scalar
Created attachment 21944 [details] [review] Proposed Patch
Created attachment 22086 [details] [review] Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verfiy that relevant authority records are linked to. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 22087 [details] [review] Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verify that relevant authority records are linked to from the bib. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 22313 [details] [review] Bug 11034: remove incorrect return for BiblioAutoLink BiblioAutoLink was being called expecting an array to be returned. The subroutine in fact returns a scalar As the variables that the return was stored in, went out of scope immediately. It is probably better to be explicit that we are throwing the return away by not going through the motions of storing it in a variable To test: [1] Add or save a bib record using the cataloging editor. [2] Verify that no regressions have occurred [3] (optional) If BiblioAddsAuthorities is on, verify that relevant authority records are linked to from the bib. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master.
Thanks, Colin!
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Colin!