Currently the CircAutoPrintQuickSlip has two options: When an empty barcode field is submitted in circulation either open a print quick slip window OR clear the screen. Can a third option be added to open a regular slip window? Our patrons want to see it all, and we'd love to make it easier to print.
Created attachment 22797 [details] Test Plan for 11040
Created attachment 22798 [details] [review] Bug 11040 Add option to print regular slip to CircAutoPrintQuickSlip
Created attachment 22852 [details] [review] Bug 11040 Add option to print regular slip to CircAutoPrintQuickSlip Test plan: 1. Set the System Preference for CircAutoPrintQuickSlip to "clear the screen". Enter a borrower barcode for checkout Press Enter The screen should be cleared. 2. Set the System Preference for CircCircAutoPrintQuickSlip to "open a quick slip window" Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 3. Apply the patch Update the database using UpdateDatabase.pl 4. Set the System Preference for CircAutoPrintQuickSlip to "clear the screen". Enter a borrower barcode for checkout Press Enter The screen should be cleared. 5. Set the System Preference for CircCircAutoPrintQuickSlip to "open a quick slip window" Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 6. Set the System Preference for CircCircAutoPrintQuickSlip to "open a slip window" Enter a borrower barcode for checkout Press Enter A Slip is printed. 7. Reload the database using sysprefs.sql Set the System Preference for CircAutoPrintQuickSlip to "clear the screen". Enter a borrower barcode for checkout Press Enter The screen should be cleared. 8. Set the System Preference for CircCircAutoPrintQuickSlip to "open a quick slip window" Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 9. Set the System Preference for CircCircAutoPrintQuickSlip to "open a slip window" Enter a borrower barcode for checkout Press Enter A Slip is printed. 10. Verify that the Checkout Help includes information about printing Slips. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
QA comment: The patch works as described. The only thing I can say is that [% IF !( CircAutoPrintQuickSlip == 'clear' ) %] could be replaced by [% UNLESS CircAutoPrintQuickSlip == 'clear' %] which I find more readable. Peggy, I will submit my qa patch replacing your name and your email. I think it is a wrong git configuration. See your .gitconfig and the wiki page: http://wiki.koha-community.org/wiki/Version_Control_Using_Git#Getting_Started_with_Git Cry aloud if I am wrong and it was wanted! Marked as Passed QA.
Created attachment 22964 [details] [review] Bug 11040 Add option to print regular slip to CircAutoPrintQuickSlip Test plan: 1. Set the System Preference for CircAutoPrintQuickSlip to "clear the screen". Enter a borrower barcode for checkout Press Enter The screen should be cleared. 2. Set the System Preference for CircCircAutoPrintQuickSlip to "open a quick slip window" Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 3. Apply the patch Update the database using UpdateDatabase.pl 4. Set the System Preference for CircAutoPrintQuickSlip to "clear the screen". Enter a borrower barcode for checkout Press Enter The screen should be cleared. 5. Set the System Preference for CircCircAutoPrintQuickSlip to "open a quick slip window" Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 6. Set the System Preference for CircCircAutoPrintQuickSlip to "open a slip window" Enter a borrower barcode for checkout Press Enter A Slip is printed. 7. Reload the database using sysprefs.sql Set the System Preference for CircAutoPrintQuickSlip to "clear the screen". Enter a borrower barcode for checkout Press Enter The screen should be cleared. 8. Set the System Preference for CircCircAutoPrintQuickSlip to "open a quick slip window" Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 9. Set the System Preference for CircCircAutoPrintQuickSlip to "open a slip window" Enter a borrower barcode for checkout Press Enter A Slip is printed. 10. Verify that the Checkout Help includes information about printing Slips. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Peggy! This appears to be your first path accepted into Koha. Congratulations!
This patch has been pushed to 3.14.x, will be in 3.14.1. (creates DBRev 3.14.00.001)