Bug 11086 - Koha Tools Upload Patron Images text description change
Summary: Koha Tools Upload Patron Images text description change
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-20 18:38 UTC by John J. Brice
Modified: 2015-06-04 23:23 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home (1.84 KB, patch)
2013-10-20 18:54 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11086 : Follow up, editing the database files also (3.49 KB, text/plain)
2013-10-20 22:43 UTC, Chris Cormack
Details
Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home (1.84 KB, patch)
2013-10-21 03:52 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home (3.65 KB, patch)
2013-10-21 03:52 UTC, Brendan Gallagher
Details | Diff | Splinter Review
[PASSED QA] Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home (1.92 KB, patch)
2013-10-27 18:37 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 11086 : Follow up, editing the database files also (3.75 KB, patch)
2013-10-27 18:37 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description John J. Brice 2013-10-20 18:38:14 UTC
Under Koha Tools Patron Images the description currently reads:

          Upload patron images in batch or one at a time

Sentence should be changed for proper English grammar and for clarity sake the line could be changed to read:

          Upload patron images in a batch or one at a time
Comment 1 Chris Cormack 2013-10-20 18:54:14 UTC Comment hidden (obsolete)
Comment 2 Bob Birchall 2013-10-20 21:15:23 UTC
We applied the patch, however at '/cgi-bin/koha/members/member-flags.pl?member=' the text of the line has not changed.

However, it has changed as expected at '/cgi-bin/koha/tools/tools-home.pl'.

Unable to sign off.
Comment 3 Bob Birchall 2013-10-20 21:31:37 UTC
We found that the second change was actually applied to the Help documentation.  A follow up is required to apply the change to the database.
Comment 4 Chris Cormack 2013-10-20 22:43:41 UTC Comment hidden (obsolete)
Comment 5 Brendan Gallagher 2013-10-21 03:52:10 UTC Comment hidden (obsolete)
Comment 6 Brendan Gallagher 2013-10-21 03:52:34 UTC Comment hidden (obsolete)
Comment 7 Brendan Gallagher 2013-10-21 03:55:53 UTC
During the process of teaching David Noe I inadvertently labeled the second patch with the wrong title.  I will fix that up in the morning.

-Brendan
Comment 8 Katrin Fischer 2013-10-27 18:37:33 UTC
Created attachment 22452 [details] [review]
[PASSED QA] Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home

To test before the patch is applied notice that on the member-flags page
it says
"upload patron images in batch or one at a time"
After the patch it should say
"upload patron images in a batch or one at a time"

Try also for tools-home

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
String change, only affecting templates.
Comment 9 Katrin Fischer 2013-10-27 18:37:48 UTC
Created attachment 22453 [details] [review]
[PASSED QA] Bug 11086 : Follow up, editing the database files also

To test before the patch is applied notice that on the member-flags page
it says
"upload patron images in batch or one at a time"
After the patch it should say
"upload patron images in a batch or one at a time"

Try also for tools-home

Signed-off-by: David Noe <drnoe@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changes permission description in en and untranslated
installer files.
Comment 10 Galen Charlton 2013-10-29 16:08:01 UTC
Pushed to master.  Thanks, Chris!
Comment 11 Tomás Cohen Arazi 2013-12-05 18:33:28 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Chris!