Bug 11089 - Item edit screen should use floating toolbar like cataloging interface
Summary: Item edit screen should use floating toolbar like cataloging interface
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on: 11088
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-20 20:01 UTC by Owen Leonard
Modified: 2016-06-25 14:12 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11089: Add floating save button to item edit screen (1.93 KB, patch)
2016-04-28 23:10 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 11089: Add floating save button to item edit screen (2.39 KB, patch)
2016-04-28 23:44 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 11089: Add floating save button to item edit screen (2.52 KB, patch)
2016-04-29 08:55 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-10-20 20:01:55 UTC
The floating toolbar, which keeps the "save" button at the top of the screen if the user scrolls down, should be added to the item edit page so that the user is not required to scroll to the bottom to make changes midway through the page.
Comment 1 Aleisha Amohia 2016-04-28 23:10:00 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2016-04-28 23:44:37 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2016-04-29 08:55:10 UTC
Created attachment 50981 [details] [review]
Bug 11089: Add floating save button to item edit screen

It was agreed in Bug 11088 that the floating save panel is used when there are no other controls which need to be displayed in a toolbar.
Thought it could be applied here.

To test:
1) Apply 11088 first
2) Apply this patch
3) Go to edit an individual item
4) Confirm that Save panel floats in bottom right corner of page and stays in this position when browser is made to be narrower or wider
5) Test with 2 active languages to ensure Save panel changes position to not be covered by language chooser

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 4 Jonathan Druart 2016-04-29 16:19:55 UTC
I personally don't like the floating button (same comment as on bug 11088).
Especially since we can have the 2 ways to display buttons on the same view: when editing 1 item (floating button) and when adding a new item (old view with 3 buttons).
Comment 5 Jonathan Druart 2016-05-02 12:13:47 UTC
Please see bug 16400 before QAing this patch.
Comment 6 Nick Clemens 2016-06-23 21:36:08 UTC
(In reply to Jonathan Druart from comment #5)
> Please see bug 16400 before QAing this patch.

I guess I cast my vote by QAing 16400 - the styling seems more consistent.

This feels slightly odd when the button floats above the items table on a record with a lot of items, perhaps if switched to the toolbar lock the highest point to the top of the form and only scroll down? That may be only personal opinion
Comment 7 Jonathan Druart 2016-06-25 14:12:33 UTC
Since bug 16400 is pushed, do we ask for another patch using a floating toolbar?