Bug 11090 - Bootstrap theme: CSS problem with suggestions toolbar links
Summary: Bootstrap theme: CSS problem with suggestions toolbar links
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/opac-suggestions.pl
Keywords:
Depends on: 10309
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-21 00:28 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11090 - Bootstrap theme: CSS problem with suggestions toolbar links (2.32 KB, patch)
2013-10-22 16:44 UTC, Owen Leonard
Details | Diff | Splinter Review
My Purchase Suggestions toolbar (95.01 KB, image/jpeg)
2013-10-22 19:30 UTC, JD@TeTakere
Details
Bug 11090 - Bootstrap theme: CSS problem with suggestions toolbar links (2.41 KB, patch)
2013-10-24 09:24 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-10-21 00:28:31 UTC
The toolbar links on the OPAC suggestions page doesn't look correct in the Bootstrap theme.
Comment 1 Owen Leonard 2013-10-22 16:44:07 UTC Comment hidden (obsolete)
Comment 2 JD@TeTakere 2013-10-22 19:30:51 UTC
Created attachment 22295 [details]
My Purchase Suggestions toolbar
Comment 3 JD@TeTakere 2013-10-22 19:31:48 UTC
Logged into Sandbox 8, viewed My Purchase Suggestions.  Toolbar looks fine (screenshot attached).
Comment 4 Jonathan Druart 2013-10-24 09:24:58 UTC
Created attachment 22348 [details] [review]
Bug 11090 - Bootstrap theme: CSS problem with suggestions toolbar links

There is a problem with the style on the toolbar on the suggestions page
which makes it float incorrectly. This patch corrects the problem.

To test, log in to the OPAC as a user who has suggestions. The
selections toolbar (which shows the "select all," etc. controls) should
look correct.

Signed-off-by: JD@TeTakere <joanned@tetakere.org.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2013-10-24 09:26:25 UTC
(In reply to JD@TeTakere from comment #3)
> Logged into Sandbox 8, viewed My Purchase Suggestions.  Toolbar looks fine
> (screenshot attached).

I added your sign off to the patch.
Please switch the status to "Signed off" instead of "Pushed for QA" when you sign off a patch.
Comment 6 Jonathan Druart 2013-10-24 09:46:35 UTC
I discovered a bug on testing this patch, see bug 11127.
Comment 7 Galen Charlton 2013-10-28 15:16:55 UTC
Pushed to master.  Thanks, Owen!