Small typo on opac-user.tt
Created attachment 22166 [details] [review] Bug 11094 - Bootstrap theme: typo loaction This patch fixes a typo on opac-user.tt
Please add a detailed commit message with a test plan. we are new patch testers and this would help us out. Thank you.
(In reply to William from comment #2) > Please add a detailed commit message with a test plan. we are new patch > testers and this would help us out. > Thank you. You are right :) I'll try to find the exact situation in which this typo surfaces (found it doing translation) and then I'll resubmit.
To test: This text is explicitly, as far as I can tell, for screen readers. Therefore, the way to test this is to inspect the source of the generated page and make sure that the text in the <span class="tdlabel"> for Pick up location shows the correct spelling of location. It's not a commit message, but I hope this test plan helps you test.
Created attachment 25106 [details] [review] [SIGNED-OFF] Bug 11094 - Bootstrap theme: typo loaction This patch fixes a typo on opac-user.tt To test you must have existing holds on your account. Log into the OPAC and view the holds tab on the "your summary" page (opac-user.pl). Resize the browser window until the table switches from a regular table layout to a vertical column. Only when the view is narrow enough does the affected label appear: Pick up location: [library name] Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 25120 [details] [review] Bug 11094 - Bootstrap theme: typo loaction This patch fixes a typo on opac-user.tt To test you must have existing holds on your account. Log into the OPAC and view the holds tab on the "your summary" page (opac-user.pl). Resize the browser window until the table switches from a regular table layout to a vertical column. Only when the view is narrow enough does the affected label appear: Pick up location: [library name] Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master. Thanks, Bernardo!
Pushed to 3.14.x, will be in 3.14.08