Bug 11094 - Bootstrap theme: typo loaction
Summary: Bootstrap theme: typo loaction
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 16:30 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11094 - Bootstrap theme: typo loaction (1.33 KB, patch)
2013-10-21 16:32 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11094 - Bootstrap theme: typo loaction (1.65 KB, patch)
2014-02-06 19:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11094 - Bootstrap theme: typo loaction (1.69 KB, patch)
2014-02-07 12:43 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2013-10-21 16:30:13 UTC
Small typo on opac-user.tt
Comment 1 Bernardo Gonzalez Kriegel 2013-10-21 16:32:30 UTC Comment hidden (obsolete)
Comment 2 William 2013-10-21 17:26:20 UTC
Please add a detailed commit message with a test plan.  we are new patch testers and this would help us out.
Thank you.
Comment 3 Bernardo Gonzalez Kriegel 2013-10-21 18:35:56 UTC
(In reply to William from comment #2)
> Please add a detailed commit message with a test plan.  we are new patch
> testers and this would help us out.
> Thank you.

You are right :)
I'll try to find the exact situation in which this typo surfaces (found it doing translation) and then I'll resubmit.
Comment 4 Liz Rea 2014-02-05 03:37:36 UTC
To test: 

This text is explicitly, as far as I can tell, for screen readers. Therefore, the way to test this is to inspect the source of the generated page and make sure that the text in the <span class="tdlabel"> for Pick up location shows the correct spelling of location.

It's not a commit message, but I hope this test plan helps you test.
Comment 5 Owen Leonard 2014-02-06 19:15:47 UTC Comment hidden (obsolete)
Comment 6 Marcel de Rooy 2014-02-07 12:43:52 UTC
Created attachment 25120 [details] [review]
Bug 11094 - Bootstrap theme: typo loaction

This patch fixes a typo on opac-user.tt

To test you must have existing holds on your account. Log into the OPAC
and view the holds tab on the "your summary" page (opac-user.pl).

Resize the browser window until the table switches from a regular table
layout to a vertical column. Only when the view is narrow enough does
the affected label appear:

Pick up location: [library name]

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Galen Charlton 2014-02-07 16:00:55 UTC
Pushed to master.  Thanks, Bernardo!
Comment 8 Fridolin Somers 2014-06-03 12:26:06 UTC
Pushed to 3.14.x, will be in 3.14.08