11104 – Label in opac topics in facets not easily css selectable

Bug 11104 - Label in opac topics in facets not easily css selectable

Summary: Label in opac topics in facets not easily css selectable

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	OPAC (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Tim Hannah
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-10-21 22:12 UTC by Tim Hannah
Modified:	2015-06-04 23:24 UTC (History)
CC List:	4 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Adds <span id... to Topics facet in opac (1.08 KB, patch) 2013-10-21 22:48 UTC, Tim Hannah	Details \| Diff \| Splinter Review
bug 11104: fixed bug in opac-facets.inc (1.14 KB, patch) 2013-10-22 00:37 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
[PASSED QA] Bug 11104: fixed bug in opac-facets.inc (1.23 KB, patch) 2013-10-22 01:18 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Patch for Series (1.23 KB, patch) 2013-10-22 20:58 UTC, Liz Rea	Details \| Diff \| Splinter Review
Deduplicating effort from the class. Places the span on Series instead of Topic (1.24 KB, patch) 2013-10-22 21:06 UTC, Liz Rea	Details \| Diff \| Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tim Hannah 2013-10-21 22:12:32 UTC

Comment 1 Tim Hannah 2013-10-21 22:48:03 UTC Comment hidden (obsolete)

Created attachment 22216 [details] [review]
Adds <span id... to Topics facet in opac

Comment 2 Martin Renvoize (ashimema) 2013-10-22 00:37:29 UTC Comment hidden (obsolete)

Created attachment 22255 [details] [review]
bug 11104: fixed bug in opac-facets.inc

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 3 Katrin Fischer 2013-10-22 01:18:27 UTC Comment hidden (obsolete)

Created attachment 22258 [details] [review]
[PASSED QA] Bug 11104: fixed bug in opac-facets.inc

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Works as advertised.

Comment 4 Liz Rea 2013-10-22 20:58:12 UTC Comment hidden (obsolete)

Created attachment 22296 [details] [review]
Patch for Series

Simply removing duplication in effort from the workshop so Tim gets credit for his work - LR

Comment 5 Liz Rea 2013-10-22 20:59:26 UTC

Comment on attachment 22296 [details] [review]
Patch for Series

Oops. Messed up.

Comment 6 Liz Rea 2013-10-22 21:06:20 UTC

Created attachment 22297 [details] [review]
Deduplicating effort from the class. Places the span on Series instead of Topic

Tim - come see me with questions :)

Liz

Comment 7 Galen Charlton 2013-12-05 15:58:39 UTC

Pushed to master.  Thanks, Tim!

Comment 8 Fridolin Somers 2013-12-13 16:11:34 UTC

This patch has been pushed to 3.14.x, will be in 3.14.1

Comment 9 Tomás Cohen Arazi (tcohen) 2013-12-27 18:05:54 UTC

This patch has been pushed to 3.12.x, will be in 3.12.9.

Thanks Tim!