Bug 11108 - undoing receiving does not appear to work (but actually does)
Summary: undoing receiving does not appear to work (but actually does)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
: 11128 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-10-22 00:10 UTC by Galen Charlton
Modified: 2015-06-04 23:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11108: fix duplicate display of basket whose receipt has just been cancelled (2.98 KB, patch)
2013-10-22 00:21 UTC, Galen Charlton
Details | Diff | Splinter Review
[SIGN-OFF]Bug 11108: fix duplicate display of basket whose receipt has just been cancelled (3.04 KB, patch)
2013-10-22 06:03 UTC, Ed Veal
Details | Diff | Splinter Review
[PASSED QA] Bug 11108: fix duplicate display of basket whose receipt has just been cancelled (3.16 KB, patch)
2013-10-27 04:12 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2013-10-22 00:10:29 UTC
If one receives an order, then after it has been marked received, undoes the receipt by using the 'Cancel receipt' link on the already-received orders page, when the page refreshes, the order is still displayed on that table.  It also is displayed on the orders-to-receive table.

This is confusing; when an receipt is undone, the order should only display on the orders-to-receive table.
Comment 1 Galen Charlton 2013-10-22 00:21:19 UTC Comment hidden (obsolete)
Comment 2 Ed Veal 2013-10-22 06:03:26 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-10-27 04:12:27 UTC
Created attachment 22441 [details] [review]
[PASSED QA] Bug 11108: fix duplicate display of basket whose receipt has just been cancelled

After receiving an order basket, before finishing receiving the shipment,
one has an option to cancel the receipt.  This patch fixes a bug where
a basket whose receipt was just cancelled displays on both the pending orders
and already received tabs.

This patch also fixes a minor unitialized variable warning.

To test:

[1] Create a basket with at least one order and close it.
[2] Receive the order, then on the row in the 'Already received'
    table, click the cancel receipt link.
[3] In the page that displays, the basket just cancelled displays
    on both tables.  Clicking the cancel receipt link again results
    in an error message.
[4] Apply the patch.
[5] Repeat steps 1 and 2.  This time, the cancelled basket displays
    only in the pending orders table, as expected.
[6] Verify that after applying the patch, the following no longer
    is logged in the Apache error log:

parcel.pl: Use of uninitialized value in string eq at acqui/parcel.pl line...

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes test plan, all tests and QA script.
Works as described.
Comment 4 Katrin Fischer 2013-10-27 04:13:28 UTC
*** Bug 11128 has been marked as a duplicate of this bug. ***
Comment 5 Galen Charlton 2013-10-28 15:06:56 UTC
Pushed to master.
Comment 6 Tomás Cohen Arazi 2013-12-05 18:30:27 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Galen!