Bug 11117 - Right to left text in facets + facet count = mixed text
Summary: Right to left text in facets + facet count = mixed text
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-22 18:49 UTC by Tomás Cohen Arazi
Modified: 2014-12-07 20:07 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Right-to-left parenthesis mixup (131.47 KB, image/png)
2013-10-22 18:49 UTC, Tomás Cohen Arazi
Details
Bug 11117: Fix text mixed in facets where RTL text + facet count showed (89.36 KB, patch)
2014-04-24 17:40 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed (89.54 KB, patch)
2014-04-24 18:00 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 11117: Fix text mixed in facets where RTL text + facet count showed (89.91 KB, patch)
2014-04-24 18:38 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed (90.03 KB, patch)
2014-04-28 16:15 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 11117: Fix text mixed in facets where RTL text + facet count showed (90.24 KB, patch)
2014-04-28 21:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2013-10-22 18:49:42 UTC
Created attachment 22294 [details]
Right-to-left parenthesis mixup

Steps to reproduce:

- Have facets to show some right to left text (for example ص) in english language templates.
- Enable the displayFacetCount.
- Check it displays like the attached snapshot.
Comment 1 Tomás Cohen Arazi 2014-04-24 17:40:55 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-04-24 18:00:15 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2014-04-24 18:38:54 UTC Comment hidden (obsolete)
Comment 4 Bernardo Gonzalez Kriegel 2014-04-28 16:15:36 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-04-28 21:38:45 UTC
Created attachment 27752 [details] [review]
[PASSED QA] Bug 11117: Fix text mixed in facets where RTL text + facet count showed

This patch adds classes for both the facet label and count, and adds
'inline-block' to the 'facet-count' class so text shows proplerly.

To reproduce:
- Have facets to show some right to left text (example on the bug report) in english language templates.
- Enable the displayFacetCount.
- Check it displays like the attached snapshot.

To test:
- Apply the patch
- Do a search that previously reproduced the problem on the staff interface
=> Shows correctly
- Repeat for OPAC (the three themes)
=> Shows correctly
- Sign off :-D

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Still work as described. Checked in arabic with arabic records.
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Confirmed bug and that the patch fixes it, tested in staff,
prog, ccsr and bootstrap.
Comment 6 Galen Charlton 2014-05-05 00:45:56 UTC
Pushed to master.  Thanks, Tomás!