Created attachment 22316 [details] [review] Bug 11124: The staff benchmark script does not work with sql administrator account On step 6 (at least), the circulation and return page redirect to the select branch page and nothing is done. The script should die if the user used is the sql administrator account. Test plan: Suppose that the sql admin account is root/root and koha/koha a superlibrarian account. 1/ perl misc/load_testing/benchmark_staff.pl --steps=6 --url=http://admin.koha.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: ... Step 6 ... 2/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="root" --user="root" should produce: Authentication successful You cannot use the database administrator account to launch this script
Patch applied cleanly, go forth and signoff
Created attachment 23333 [details] [review] Bug 11124: The staff benchmark script does not work with sql administrator account On step 6 (at least), the circulation and return page redirect to the select branch page and nothing is done. The script should die if the user used is the sql administrator account. Test plan: Suppose that the sql admin account is root/root and koha/koha a superlibrarian account. 1/ perl misc/load_testing/benchmark_staff.pl --steps=6 --url=http://admin.koha.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: ... Step 6 ... 2/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="root" --user="root" should produce: Authentication successful You cannot use the database administrator account to launch this script Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 23334 [details] [review] Bug 11124: QA Follow-up resolving a warning and three typos Resolves warning on uninitialized author in split on line 128. Just adds the same behavior for title on line 129 for completeness. Fixes typo on occurrences and two other minor typos. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 23335 [details] [review] Bug 11124: QA Follow-up adding optional dependency HTTPD::Bench::ApacheBench This dependency is used in load testing (misc/load_testing/*) Test plan: Check if you see the dependency listed on About/Perl modules. Verify if the version information is correct. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 23536 [details] [review] Bug 11124: The staff benchmark script does not work with sql administrator account On step 6 (at least), the circulation and return page redirect to the select branch page and nothing is done. The script should die if the user used is the sql administrator account. Test plan: Suppose that the sql admin account is root/root and koha/koha a superlibrarian account. 1/ perl misc/load_testing/benchmark_staff.pl --steps=6 --url=http://admin.koha.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: ... Step 6 ... 2/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="root" --user="root" should produce: Authentication successful You cannot use the database administrator account to launch this script Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 23537 [details] [review] Bug 11124: QA Follow-up resolving a warning and three typos Resolves warning on uninitialized author in split on line 128. Just adds the same behavior for title on line 129 for completeness. Fixes typo on occurrences and two other minor typos. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 23538 [details] [review] Bug 11124: QA Follow-up adding optional dependency HTTPD::Bench::ApacheBench This dependency is used in load testing (misc/load_testing/*) Test plan: Check if you see the dependency listed on About/Perl modules. Verify if the version information is correct. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Jonathan!
Patches pushed to 3.14.x, will be in 3.14.2