There are a couple of markup errors in the new OPAC place hold form. They don't appear to cause problems but should be fixed for validity's sake.
Created attachment 22411 [details] [review] Bug 11133 - Markup errors in OPAC place hold form HTML There are markup errors in the OPAC place hold form which prevent it from validating successfully. These errors don't seem to cause any visual problem but can potentially cause problems when debugging template logic. To test, apply the patch and validate the page using your preferred validator (since it's a page which requires login you'll have to upload or paste the source). The page should validate successfully. Test when placing holds on: - a single item - multiple items - items which you cannot place on hold
I should specify: This patch is for the prog template. A separate bug will address the bootstrap template.
Created attachment 22418 [details] [review] Bug 11133 - Markup errors in OPAC place hold form HTML There are markup errors in the OPAC place hold form which prevent it from validating successfully. These errors don't seem to cause any visual problem but can potentially cause problems when debugging template logic. To test, apply the patch and validate the page using your preferred validator (since it's a page which requires login you'll have to upload or paste the source). The page should validate successfully. Test when placing holds on: - a single item - multiple items - items which you cannot place on hold Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 22454 [details] [review] [PASSED QA] Bug 11133 - Markup errors in OPAC place hold form HTML There are markup errors in the OPAC place hold form which prevent it from validating successfully. These errors don't seem to cause any visual problem but can potentially cause problems when debugging template logic. To test, apply the patch and validate the page using your preferred validator (since it's a page which requires login you'll have to upload or paste the source). The page should validate successfully. Test when placing holds on: - a single item - multiple items - items which you cannot place on hold Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested according to test plan and validated souce code with W3C Validator.
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen!