Bug 11133 - Markup errors in OPAC place hold form HTML
Summary: Markup errors in OPAC place hold form HTML
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 15:07 UTC by Owen Leonard
Modified: 2015-06-04 23:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11133 - Markup errors in OPAC place hold form HTML (1.83 KB, patch)
2013-10-25 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11133 - Markup errors in OPAC place hold form HTML (1.84 KB, patch)
2013-10-25 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 11133 - Markup errors in OPAC place hold form HTML (2.01 KB, patch)
2013-10-27 18:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-10-24 15:07:48 UTC
There are a couple of markup errors in the new OPAC place hold form. They don't appear to cause problems but should be fixed for validity's sake.
Comment 1 Owen Leonard 2013-10-25 14:43:36 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-10-25 14:44:37 UTC
I should specify: This patch is for the prog template. A separate bug will address the bootstrap template.
Comment 3 Kyle M Hall 2013-10-25 16:09:44 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-10-27 18:56:14 UTC
Created attachment 22454 [details] [review]
[PASSED QA] Bug 11133 - Markup errors in OPAC place hold form HTML

There are markup errors in the OPAC place hold form which prevent it
from validating successfully. These errors don't seem to cause any
visual problem but can potentially cause problems when debugging
template logic.

To test, apply the patch and validate the page using your preferred
validator (since it's a page which requires login you'll have to upload
or paste the source). The page should validate successfully. Test when
placing holds on:

- a single item
- multiple items
- items which you cannot place on hold

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Tested according to test plan and validated souce code with
W3C Validator.
Comment 5 Galen Charlton 2013-10-28 15:03:33 UTC
Pushed to master.  Thanks, Owen!
Comment 6 Tomás Cohen Arazi 2013-12-08 15:10:35 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Owen!