The recently added environment variable OVERRIDE_SYSPREF_NAMES is parsed using split but most of the time we're splitting an undefined variable. This fills the error log with warnings, so we should check theres something to split before executing it
Created attachment 22373 [details] [review] Proposed patch lets take warnings seriously folks To test this patch should stop 'Use of uninitialized value in split' be generated when viewing and updating system preferences
Created attachment 22632 [details] [review] Bug 11135 Check variable exists before splitting calling split on an undefined var generates warning to the log. Lets check it exists before processing it Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
As an exception to the rule, I take the liberty to sign off and pass qa in one run. This is a trivial patch that eliminates just another warning from the logs. Good catch.
Pushed to master, along with a pendantic follow-up. Thanks, Colin! I sure wish there were a less verbose way to simultaneously check that a hash key is present and that the value of it is defined, but c'est la vie.