Bug 11142 - Update Bootstrap theme's place hold form to match the new version in prog
Summary: Update Bootstrap theme's place hold form to match the new version in prog
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-25 14:46 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
[PATCH] Bug 11142 - Update Bootstrap theme's place hold form to match the new version in prog (55.95 KB, patch)
2013-10-28 17:11 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11142 - Update Bootstrap theme's place hold form to match the new version in prog (56.09 KB, patch)
2013-10-30 01:16 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-10-25 14:46:26 UTC
A change was recently made to the place hold form in the prog theme. This change needs to be made to the Bootstrap theme as well.
Comment 1 Owen Leonard 2013-10-28 17:11:47 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-10-30 01:16:25 UTC
Created attachment 22531 [details] [review]
[SIGNED-OFF] Bug 11142 - Update Bootstrap theme's place hold form to match the new version in prog

The update to the prog theme's place hold page (Bug 10836) happened
after the Bootstrap theme's place hold form had already been converted,
so it lags behind. This patch applies the changes made to prog to Bootstrap.

To test, switch to the Bootstrap theme and follow the test plan from Bug
10836:

Place single and multiple holds under various conditions:

- Items which are not available to be place on hold
- With OpacHoldNotes on and off
- With OPACItemHolds on and off
- With OPACAllowHoldDateInFuture on and off
- With IndependentBranches on and off
- With JavaScript disabled

Test setting hold notes, holding specific copies, and setting hold start
dates. When setting a hold start date and hold expiration date, the two
datepickers should work together to prevent invalid date combinations
(dates after today, expiration dates which precede the start date).

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No koha-qa errors. Works as described, very well.

Tested all situations, all syspref, and without JavaScript.
Comment 3 Galen Charlton 2013-10-31 16:59:44 UTC
Electing to push this to master now so that Bootstrap becoming the default theme does not effectively cause a regression of bug 10836.

Thanks, Owen!