Bug 11159 - Small typo in catalogue/results.tt
Summary: Small typo in catalogue/results.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-29 13:17 UTC by Fridolin Somers
Modified: 2015-06-04 23:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11159 - Small typo in catalogue/results.tt (1.87 KB, patch)
2013-10-29 13:24 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 11159 - Small typo in catalogue/results.tt (1.96 KB, patch)
2013-11-08 15:46 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-10-29 13:17:04 UTC
In catalogue/results.tt, there is a small HTML error line 377 :
[% ELSE %]<option value"au,phr">Author</option>[% END %]
The = is missing
Comment 1 Fridolin Somers 2013-10-29 13:24:01 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2013-11-08 15:46:39 UTC
Created attachment 22830 [details] [review]
Bug 11159 - Small typo in catalogue/results.tt

In catalogue/results.tt, there is a small HTML error line 377 :
[% ELSE %]<option value"au,phr">Author</option>[% END %]
The = is missing

Test plan :
- In intranet, test go to advanced search
- Click on [More options]
- Enter a term, check "Scan indexes" and click on "Search"
- Look at HTML code of select "Indexed in"
=> option "Author" is correct : <option value="au,phr">Author</option>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2013-11-08 15:47:56 UTC
Taking the liberty for this trivial string patch to upgrade it to Passed QA.
No string change, just html.
Comment 4 Galen Charlton 2013-11-08 16:30:09 UTC
Pushed to master.  Thanks, Fridolin!
Comment 5 Tomás Cohen Arazi 2013-12-08 15:09:31 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Fridolin!