Child fund is confusing in the US and we would like to see 'sub fund' since that's what we'd call it here.
Created attachment 97269 [details] [review] Bug 11161: Relabel 'child fund' to 'sub fund' in staff interface It was noted, that 'sub fund' might be a better term to use than 'child fund'. So this patch changes it. To test, check with and without patch: - Add a budget in acquisitions - Add a fund in acquisitions - Add a sub/child fund to your fund (label of menu item #1) - Edit your first fund, check option to update owners of sub/child funds (#2) - Try to delete your 'parent' fund (tooltip #3) - Click on the greyed out entry (alert ÃÃ#4) If you like the chane, please sign-off. If you think otherwise, please comment on the bug report.
This was a quick change actually, so putting the patch up and see what people think :)
I tried signing this off on the PTFS Sandbox, but it doesn't seem to apply correctly.
Created attachment 98274 [details] [review] Bug 11161: Relabel 'child fund' to 'sub fund' in staff interface It was noted, that 'sub fund' might be a better term to use than 'child fund'. So this patch changes it. To test, check with and without patch: - Add a budget in acquisitions - Add a fund in acquisitions - Add a sub/child fund to your fund (label of menu item #1) - Edit your first fund, check option to update owners of sub/child funds (#2) - Try to delete your 'parent' fund (tooltip #3) - Click on the greyed out entry (alert ÃÃ#4) If you like the change, please sign-off. If you think otherwise, please comment on the bug report. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 99368 [details] [review] Bug 11161: Relabel 'child fund' to 'sub fund' in staff interface It was noted, that 'sub fund' might be a better term to use than 'child fund'. So this patch changes it. To test, check with and without patch: - Add a budget in acquisitions - Add a fund in acquisitions - Add a sub/child fund to your fund (label of menu item #1) - Edit your first fund, check option to update owners of sub/child funds (#2) - Try to delete your 'parent' fund (tooltip #3) - Click on the greyed out entry (alert ÃÃ#4) If you like the chane, please sign-off. If you think otherwise, please comment on the bug report. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Maybe also admin/aqbudgets.pl: die("Delete a fund with children is not possible"); But not important..
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11.x