In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. The bug is that the filter uses a pattern match instead of equals : next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'.
Created attachment 22573 [details] [review] Bug 11166 - branch filter in budgets admin uses pattern match instead of equals See commit message
Created attachment 23566 [details] [review] Bug 11166 - branch filter in budgets admin uses pattern match instead of equals In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. The bug is that the filter uses a pattern match instead of equals : next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'. Test plan : - Create a branch with code '1' and one with code '12' - Create budgets in both branches - Go to admin/aqbudgets.pl - Filter by branch '12' => You see only budgets of this branch - Filter by branch '1' => You see only budgets of this branch Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 23724 [details] [review] Bug 11166 - branch filter in budgets admin uses pattern match instead of equals In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. The bug is that the filter uses a pattern match instead of equals : next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'. Test plan : - Create a branch with code '1' and one with code '12' - Create budgets in both branches - Go to admin/aqbudgets.pl - Filter by branch '12' => You see only budgets of this branch - Filter by branch '1' => You see only budgets of this branch Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised
Pushed to master. Thanks, Fridolin!
Patch pushed to 3.14.x, will be in 3.14.2
This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Fridolin!