11171 – The basket group is not displayed on the supplier list page

Bug 11171 - The basket group is not displayed on the supplier list page

Summary: The basket group is not displayed on the supplier list page

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Acquisitions (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Jonathan Druart
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-10-30 14:50 UTC by Jonathan Druart
Modified:	2015-06-04 23:23 UTC (History)
CC List:	2 users (show)

See Also:	11111
Change sponsored?:	---
Patch complexity:	Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11171: Display basket group name on the supplier list page (3.16 KB, patch) 2013-10-30 14:52 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
[SIGNED-OFF] Bug 11171: Display basket group name on the supplier list page (3.25 KB, patch) 2013-11-14 15:47 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 11171: FIX a javascript error (1.31 KB, patch) 2013-11-25 08:37 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
[PASSED QA] Bug 11171: Display basket group name on the supplier list page (3.33 KB, patch) 2013-11-25 20:59 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
[PASSED QA] Bug 11171: FIX a javascript error (1.37 KB, patch) 2013-11-25 20:59 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2013-10-30 14:50:39 UTC

Comment 1 Jonathan Druart 2013-10-30 14:52:43 UTC Comment hidden (obsolete)

Created attachment 22598 [details] [review]
Bug 11171: Display basket group name on the supplier list page

Test plan:
search supplier and verify the basket group column is filled.

Comment 2 Owen Leonard 2013-11-14 15:47:28 UTC Comment hidden (obsolete)

Created attachment 22936 [details] [review]
[SIGNED-OFF] Bug 11171: Display basket group name on the supplier list page

Test plan:
search supplier and verify the basket group column is filled.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Katrin Fischer 2013-11-25 07:29:03 UTC

I am sorry, but with this patch we have a Javascript error on the page:
TypeError: a.aoColumns[c] is undefined
http://localhost:8080/intranet-tmpl/lib/jquery/jquery.js
Line 3

Comment 4 Jonathan Druart 2013-11-25 08:37:36 UTC Comment hidden (obsolete)

Created attachment 23130 [details] [review]
Bug 11171: FIX a javascript error

The previous patch adds an error on booksellers.pl:

TypeError: a.aoColumns[c] is undefined

It was caused by the add of the new column. The aoColumns DT parameter
should manage it.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Comment 5 Katrin Fischer 2013-11-25 20:59:47 UTC

Created attachment 23148 [details] [review]
[PASSED QA] Bug 11171: Display basket group name on the supplier list page

Test plan:
search supplier and verify the basket group column is filled.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Works as described.

Comment 6 Katrin Fischer 2013-11-25 20:59:51 UTC

Created attachment 23149 [details] [review]
[PASSED QA] Bug 11171: FIX a javascript error

The previous patch adds an error on booksellers.pl:

TypeError: a.aoColumns[c] is undefined

It was caused by the add of the new column. The aoColumns DT parameter
should manage it.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

Comment 7 Galen Charlton 2013-11-27 18:04:43 UTC

Pushed to master.  Thanks, Jonathan!

Comment 8 Fridolin Somers 2013-12-13 14:00:30 UTC

Those patches has been pushed to 3.14.x, will be in 3.14.1