If an item is listed for a course and is checked out, the item will still show as being available from the course details page which lists all the items that are part of a course. This is due to the way the course reserves system handles items and issues separately, while item-status.inc assumes the due date has been embedded in items.datedue
Created attachment 22659 [details] [review] Bug 11179 - opac-course-details.pl shows item as available when it is checked out If an item is listed for a course and is checked out, the item will still show as being available from the course details page which lists all the items that are part of a course. This is due to the way the course reserves system handles items and issues separately, while item-status.inc assumes the due date has been embedded in items.datedue Test Plan: 1) Create a course 2) Add an item to that course 3) Check the item out to a patron 4) View the course details from the opac 5) Note the status says "Available" 6) Apply this patch 7) Repeat step 4 8) Note the status no longer says "Available"
Created attachment 22950 [details] [review] [SIGNED-OFF] Bug 11179 - opac-course-details.pl shows item as available when it is checked out If an item is listed for a course and is checked out, the item will still show as being available from the course details page which lists all the items that are part of a course. This is due to the way the course reserves system handles items and issues separately, while item-status.inc assumes the due date has been embedded in items.datedue Test Plan: 1) Create a course 2) Add an item to that course 3) Check the item out to a patron 4) View the course details from the opac 5) Note the status says "Available" 6) Apply this patch 7) Repeat step 4 8) Note the status no longer says "Available" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 22951 [details] [review] Bug 11179 [Follow-up] opac-course-details.pl shows item as available when it is checked out This follow-up applies the same fix to the Bootstrap theme. This patch also includes the changes to item-status.inc in the Bootstrap theme which were made to the prog theme in Bug 10820: display item status as lost if item is both lost and on loan.
Created attachment 23012 [details] [review] Bug 11179 [Follow-up] opac-course-details.pl shows item as available when it is checked out This follow-up applies the same fix to the Bootstrap theme. This patch also includes the changes to item-status.inc in the Bootstrap theme which were made to the prog theme in Bug 10820: display item status as lost if item is both lost and on loan. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Bootstrap theme looking so nice. Also the patch works.
QA comment: Works as expected on both OPAC themes. I am just wondering if we should not add a comment in the include file in order to explain why sometimes there is an issue parameter and sometimes not. I think it can be confusing for new calls to this inc. Marked as Passed QA.
Created attachment 23020 [details] [review] Bug 11179 - opac-course-details.pl shows item as available when it is checked out If an item is listed for a course and is checked out, the item will still show as being available from the course details page which lists all the items that are part of a course. This is due to the way the course reserves system handles items and issues separately, while item-status.inc assumes the due date has been embedded in items.datedue Test Plan: 1) Create a course 2) Add an item to that course 3) Check the item out to a patron 4) View the course details from the opac 5) Note the status says "Available" 6) Apply this patch 7) Repeat step 4 8) Note the status no longer says "Available" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 23021 [details] [review] Bug 11179 [Follow-up] opac-course-details.pl shows item as available when it is checked out This follow-up applies the same fix to the Bootstrap theme. This patch also includes the changes to item-status.inc in the Bootstrap theme which were made to the prog theme in Bug 10820: display item status as lost if item is both lost and on loan. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Bootstrap theme looking so nice. Also the patch works. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 23028 [details] [review] Bug 11179 [Follow-up] opac-course-details.pl shows item as available when it is checked out This follow-up applies the same fix to the Bootstrap theme. This patch also includes the changes to item-status.inc in the Bootstrap theme which were made to the prog theme in Bug 10820: display item status as lost if item is both lost and on loan. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Bootstrap theme looking so nice. Also the patch works. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master, along with a follow-up that adds a comment to item-status.inc to describe the parameters it accepts. Thanks, Kyle and Owen! However, the wart in the API that means that item.datedue is not always set, depending on how you retrieve the item, should be fixed. In the long run, it should either never be necessary to supply a separate issues parameter to the template or it should always be necessary.
Patches pushed to 3.14.x, will be in 3.14.3.