Eliminate unnecessary warnings
Created attachment 22662 [details] [review] bug_11182: get rid of some warnings To testi - circulation: * For a child patron, check that "Upgrade to adult" link on the "More" drop-down is clickable * Set sys pref FineNotifyAtCheckin to yes (Notify), and check in an overdue item that attracts fine. Fine amount should be displayed.
Created attachment 22864 [details] [review] bug_11182: get rid of some warnings To test - circulation: * For a child patron, check that "Upgrade to adult" link on the "More" drop-down is clickable * Set sys pref FineNotifyAtCheckin to yes (Notify), and check in an overdue item that attracts fine. Fine amount should be displayed.
Created attachment 22865 [details] [review] bug_11182: get rid of some warnings To test - circulation: * For a child patron, check that "Upgrade to adult" link on the "More" drop-down is clickable * Set sys pref FineNotifyAtCheckin to yes (Notify), and check in an overdue item that attracts fine. Fine amount should be displayed.
Found some additional circ/circulations.pl warnings.
Created attachment 24171 [details] [review] Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken.
Sorry to make this a split effort, but since my error log entries really did overlap with this bug, I figured I'd add my patch here. :)
Created attachment 24179 [details] [review] Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries.
Comment on attachment 24171 [details] [review] Bug 11182 - Warnings in circulation Silly git bz obsoleted this. :)
Created attachment 24181 [details] [review] [SIGNED OFF] Bug 11182 - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 24196 [details] [review] Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com>
Created attachment 24198 [details] [review] Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com>
Created attachment 24209 [details] [review] Bug 11182 - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 24516 [details] [review] Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24517 [details] [review] Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24518 [details] [review] Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24519 [details] [review] Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24520 [details] [review] Bug 11182 - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24522 [details] [review] Bug 11182 [1] - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24523 [details] [review] Bug 11182 [2] - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24524 [details] [review] Bug 11182 [3] - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24955 [details] [review] Bug 11182 [1] - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 24956 [details] [review] Bug 11182 [2] - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 24957 [details] [review] Bug 11182 [3] - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 24958 [details] [review] Bug 11182: (QA followup) warning if itemBarcodeFallbackSearch set To reproduce: - On top of the previous patches, if you enable the itemBarcodeFallbackSearch syspref and do a search for a term that returns at least one result, there will be warnings for each result without items attached. To test: - In the checkout form enter a term that should return results (some of them without items attached) => There are warnings on the logs regarding a split of undef variable - Apply the patch - Repeat the first step => No warings
Pushed to master. Thanks, Srdjan, Mark, and Tomás!