SearchEngine pref was introduced in updatedatabase.pl, but not in sysprefs.sql, so new installs don't have it set by default
Created attachment 22678 [details] [review] bug_11196: put SearchEngine to sysprefs.sql Test: Check that sysprefs.sql runs correctly.
Created attachment 22858 [details] [review] [SIGNED OFF] bug_11196: put SearchEngine to sysprefs.sql Test: Check that sysprefs.sql runs correctly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
I dropped my koha database, and did a fresh install from master. Indeed it was missing. I changed the version number back to 3.6000000 in the systempreferences table and forced an upgrade. Lo and behold it appeared. I dropped my koha database again, applied the patch, and did a fresh install again. This time the system preference was there as expected. I even discovered Frameworksloaded, marcflavor, and Version are all created by the installer, when I deleted everything in the system preferences table and sourced the sql file directly. It was disorienting to see that the variable count had dropped. No worries, though. This all was a test system. :)
Created attachment 22904 [details] [review] bug_11196: put SearchEngine to sysprefs.sql Test: Check that sysprefs.sql runs correctly. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 22905 [details] [review] Bug 11196: Add SearchEngine syspref in the DB if missing Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
The pref should be added too for installation created between 3.09.00.023 and now. Marked as Passed QA.
I should have thought of that myself... We resolved it by going to the syspref admin.
Since this is easy to test and quiets log noise, I've pushed this to master and 3.14.x. Thanks, Srdjan!