Bug 11204 - pendingreserves should use datatables.inc
Summary: pendingreserves should use datatables.inc
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low normal
Assignee: Galen Charlton
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 16:58 UTC by Jonathan Druart
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11204: pendingreserves should use datatables.inc (1.36 KB, patch)
2013-11-05 16:59 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 11204: pendingreserves should use datatables.inc (1.42 KB, patch)
2013-11-06 05:45 UTC, Brendan Gallagher 		Details | Diff | Splinter Review
Bug 11204: pendingreserves should use datatables.inc (1.51 KB, patch)
2013-11-06 15:31 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-11-05 16:58:07 UTC 
A JS error occurs on the pending reserves pages:

ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined
if(CONFIG_EXCLUDE_ARTICLES_FROM_SORT){
Comment 1 Jonathan Druart 2013-11-05 16:59:30 UTC Comment hidden (obsolete)
Comment 2 Brendan Gallagher 2013-11-06 05:45:19 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-11-06 15:31:50 UTC 
Created attachment 22754 [details] [review]
Bug 11204: pendingreserves should use datatables.inc

A JS error occurs on the pending reserves pages:

ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined
if(CONFIG_EXCLUDE_ARTICLES_FROM_SORT){

Test plan:
Apply the patch and verify the error does not appear anymore.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Galen Charlton 2013-11-06 15:36:01 UTC 
Pushed to master and 3.14.x.  Thanks, Jonathan!