Bug 11216 - Patron modification creates indefinite manual restriction
Summary: Patron modification creates indefinite manual restriction
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P1 - high blocker (vote)
Assignee: Dobrica Pavlinusic
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks: 11240
  Show dependency treegraph
 
Reported: 2013-11-07 15:19 UTC by Dobrica Pavlinusic
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11216 - Patron modification creates indefinite manual restriction (2.76 KB, patch)
2013-11-08 13:58 UTC, Dobrica Pavlinusic
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11216 - Patron modification creates indefinite manual restriction (2.86 KB, patch)
2013-11-08 14:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11216 - Patron modification creates indefinite manual restriction (3.19 KB, patch)
2013-11-08 14:50 UTC, Dobrica Pavlinusic
Details | Diff | Splinter Review
Bug 11216 - Patron modification creates indefinite manual restriction (3.38 KB, patch)
2013-11-12 21:35 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11216 - Patron modification creates indefinite manual restriction (3.44 KB, patch)
2013-11-13 08:49 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Dobrica Pavlinusic 2013-11-07 15:19:35 UTC

    
Comment 1 Dobrica Pavlinusic 2013-11-08 13:58:29 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-11-08 14:27:27 UTC Comment hidden (obsolete)
Comment 3 Dobrica Pavlinusic 2013-11-08 14:50:55 UTC Comment hidden (obsolete)
Comment 4 Dobrica Pavlinusic 2013-11-08 14:52:31 UTC
Sorry Owen, I found another place which needs care when canceling debarment, so I obsoleted your sign-off
Comment 5 Chris Cormack 2013-11-12 21:31:02 UTC
I confirm this bug, testing the fix now
Comment 6 Chris Cormack 2013-11-12 21:35:30 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2013-11-13 08:49:44 UTC
Created attachment 22894 [details] [review]
Bug 11216 - Patron modification creates indefinite manual restriction

Editing partron data results in unintended adding of indefinite manual
restriction to it. Reason for it is hidden field add_debarment which
is wrongly initialized to 1 instead of 0. Also JavaScript code seems
to want to toggle checkbox, and sice this field is hidden correct
approach would be to change it's value to 1.

Test scenario:

1. edit patron data
2. verify that debarrment is wrongly added
3. remove debarrment
3. apply this patch
4. edit patron again
5. verify that debarrment wasn't added
6. intentionally add debarrment and verify that it's saved
7. add debarment, enter something in comment but press cancel
   and verify that debarment isn't added

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

This fixes this blocker, however, with or without the patch, the date
is not saved correctly. I will file a new bug for that

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Galen Charlton 2013-11-14 15:45:44 UTC
Pushed to master and 3.14.x.  Thanks, Dobrica!